Fix closure bugs in Dygraphs #237
Conversation
Also fix bug: this.labels_ was never used! Booo...
| * Returns the box which the chart should be drawn in. This is the canvas's | ||
| * box, less space needed for the axis and chart labels. | ||
| * | ||
| * @return {{ x : numer, y : number, w : number, h : number }} |
There was a problem hiding this comment.
I haven't seen this much whitespace in other closure type definitions. This is typically written as:
- @return {{x: number, y: number, w: number, h: number}}
|
Have you run this through the closure compiler? I'm not sure there's much value in closure-izing unless you can get the code through the compiler. |
|
It seems like there's some overlap here with pull request 233. Which should I pull? |
|
Take 233 and I'll go from there. |
|
Done. On Thu, Apr 11, 2013 at 7:47 AM, Robert Konigsberg <[email protected]
|
Conflicts: dygraph-options.js
| * | ||
| * This function can only be called if DygraphLayout's points array has been | ||
| * updated with canvas{x,y} attributes, i.e. by | ||
| * DygraphCanvasRenderer._updatePoints. | ||
| * | ||
| * @param {string=} opt_seriesName when specified, only that series will | ||
| * be drawn. (This is used for expedited redrawing with highlightSeriesOpts) |
There was a problem hiding this comment.
we typically indent continuation lines four spaces when they're part of jsdoc comments
|
Look good, feel free to pull after addressing the comments I gave you. |
|
Done. Merging. |
No description provided.