Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: base project structure #2

Merged
merged 6 commits into from
Sep 17, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat: fix typo in project name and add workflow for pull requests
  • Loading branch information
danfimov committed Sep 17, 2023
commit 8a270a7fe52fd0e90d1b81d1071a5ca42703faef
27 changes: 27 additions & 0 deletions .github/workflows/code-check.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
name: Checks
on: [pull_request]

jobs:
lint:
runs-on: ubuntu-latest
name: Lint code
steps:
- uses: actions/checkout@v2
- uses: actions/setup-python@v4
with:
python-version: '3.11'
- run: pip install --upgrade pip
- run: make install
- run: make lint
test:
runs-on: ubuntu-latest
name: Run tests
steps:
- uses: actions/checkout@v2
- uses: actions/setup-python@v4
with:
python-version: '3.11'
- run: pip install --upgrade pip
- run: make install
- run: make test-cov
g
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
args := $(wordlist 2, 100, $(MAKECMDGOALS))

APPLICATION_NAME = ya_tacker_client
APPLICATION_NAME = ya_tracker_client

HELP_FUN = \
%help; while(<>){push@{$$help{$$2//'options'}},[$$1,$$3] \
if/^([\w-_]+)\s*:.*\#\#(?:@(\w+))?\s(.*)$$/}; \
print"$$_:\n", map" $$_->[0]".(" "x(20-length($$_->[0])))."$$_->[1]\n",\
@{$$help{$$_}},"\n" for keys %help; \

CODE = ya_tacker_client
CODE = ya_tracker_client
TEST = poetry run python3 -m pytest --verbosity=2 --showlocals --log-level=DEBUG

ifndef args
Expand Down
2 changes: 1 addition & 1 deletion examples/get_issue.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

from dotenv import load_dotenv

from ya_tacker_client import YaTrackerClient
from ya_tracker_client import YaTrackerClient


load_dotenv()
Expand Down
2 changes: 1 addition & 1 deletion tests/fixtures/issue.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from polyfactory.factories.pydantic_factory import ModelFactory
from polyfactory.pytest_plugin import register_fixture

from ya_tacker_client.domain.entities.issue import Issue
from ya_tracker_client.domain.entities.issue import Issue


@register_fixture
Expand Down
4 changes: 2 additions & 2 deletions tests/test_domain/test_client/test_initialization.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@

import pytest

from ya_tacker_client.domain.client import BaseClient
from ya_tacker_client.domain.client.errors import ClientInitTokenError
from ya_tracker_client.domain.client import BaseClient
from ya_tracker_client.domain.client.errors import ClientInitTokenError


class ClientForTestInitialization(BaseClient):
Expand Down
4 changes: 2 additions & 2 deletions tests/test_domain/test_client/test_request.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@

import pytest

from ya_tacker_client.domain.client import BaseClient
from ya_tacker_client.domain.client.errors import (
from ya_tracker_client.domain.client import BaseClient
from ya_tracker_client.domain.client.errors import (
ClientAuthError,
ClientError,
ClientObjectConflictError,
Expand Down
7 changes: 3 additions & 4 deletions tests/test_domain/test_repositories/test_issue_repository.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,9 @@
import pytest

from tests.fixtures.issue import IssueFactory

from ya_tacker_client.domain.client import BaseClient
from ya_tacker_client.domain.client.errors import ClientObjectNotFoundError
from ya_tacker_client.domain.repositories.issue import IssueRepository
from ya_tracker_client.domain.client import BaseClient
from ya_tracker_client.domain.client.errors import ClientObjectNotFoundError
from ya_tracker_client.domain.repositories.issue import IssueRepository


class ClientForIssueRepository(BaseClient):
Expand Down
6 changes: 0 additions & 6 deletions ya_tacker_client/__init__.py

This file was deleted.

6 changes: 6 additions & 0 deletions ya_tracker_client/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
from ya_tracker_client.service.api import YaTrackerClient


__all__ = [
"YaTrackerClient",
]
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
from logging import getLogger
from typing import Any

from ya_tacker_client.domain.client.errors import (
from ya_tracker_client.domain.client.errors import (
ClientAuthError,
ClientError,
ClientInitTokenError,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@

from pydantic import AliasChoices, Field

from ya_tacker_client.domain.entities.base import AbstractEntity
from ya_tacker_client.domain.entities.priority import Priority
from ya_tacker_client.domain.entities.queue import Queue
from ya_tacker_client.domain.entities.sprint import Sprint
from ya_tacker_client.domain.entities.status import Status
from ya_tacker_client.domain.entities.user import User
from ya_tracker_client.domain.entities.base import AbstractEntity
from ya_tracker_client.domain.entities.priority import Priority
from ya_tracker_client.domain.entities.queue import Queue
from ya_tracker_client.domain.entities.sprint import Sprint
from ya_tracker_client.domain.entities.status import Status
from ya_tracker_client.domain.entities.user import User


class IssueShort(AbstractEntity):
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
from pydantic import AliasChoices, Field

from ya_tacker_client.domain.entities.base import AbstractEntity
from ya_tracker_client.domain.entities.base import AbstractEntity


class Priority(AbstractEntity):
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
from pydantic import AliasChoices, Field

from ya_tacker_client.domain.entities.base import AbstractEntity
from ya_tracker_client.domain.entities.base import AbstractEntity


class Queue(AbstractEntity):
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
from pydantic import AliasChoices, Field

from ya_tacker_client.domain.entities.base import AbstractEntity
from ya_tracker_client.domain.entities.base import AbstractEntity


class Sprint(AbstractEntity):
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
from pydantic import AliasChoices, Field

from ya_tacker_client.domain.entities.base import AbstractEntity
from ya_tracker_client.domain.entities.base import AbstractEntity


class Status(AbstractEntity):
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
from pydantic import AliasChoices, Field

from ya_tacker_client.domain.entities.base import AbstractEntity
from ya_tracker_client.domain.entities.base import AbstractEntity


class User(AbstractEntity):
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from ya_tacker_client.domain.client import BaseClient
from ya_tracker_client.domain.client import BaseClient


class EntityRepository:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from json import loads

from ya_tacker_client.domain.entities.issue import Issue
from ya_tacker_client.domain.repositories.base import EntityRepository
from ya_tracker_client.domain.entities.issue import Issue
from ya_tracker_client.domain.repositories.base import EntityRepository


class IssueRepository(EntityRepository):
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
from aiohttp import ClientSession, ClientTimeout, TCPConnector
from certifi import where

from ya_tacker_client.domain.client import BaseClient
from ya_tracker_client.domain.client import BaseClient


logger = getLogger(__name__)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
from ya_tacker_client.domain.repositories.issue import IssueRepository
from ya_tacker_client.infrastructure.client import AiohttpClient
from ya_tracker_client.domain.repositories.issue import IssueRepository
from ya_tracker_client.infrastructure.client import AiohttpClient


class YaTrackerClient(IssueRepository):
Expand Down