Skip to content

Commit

Permalink
block/scsi-ioctl: Fix kernel-infoleak in scsi_put_cdrom_generic_arg()
Browse files Browse the repository at this point in the history
scsi_put_cdrom_generic_arg() is copying uninitialized stack memory to
userspace, since the compiler may leave a 3-byte hole in the middle of
`cgc32`. Fix it by adding a padding field to `struct
compat_cdrom_generic_command`.

Cc: [email protected]
Fixes: f3ee6e6 ("compat_ioctl: move CDROM_SEND_PACKET handling into scsi")
Suggested-by: Dan Carpenter <[email protected]>
Suggested-by: Arnd Bergmann <[email protected]>
Reported-by: [email protected]
Signed-off-by: Peilin Ye <[email protected]>
Signed-off-by: Jens Axboe <[email protected]>
  • Loading branch information
peilin-ye authored and axboe committed Oct 2, 2020
1 parent 632bfb6 commit 6d53a9f
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions block/scsi_ioctl.c
Original file line number Diff line number Diff line change
Expand Up @@ -651,6 +651,7 @@ struct compat_cdrom_generic_command {
compat_int_t stat;
compat_caddr_t sense;
unsigned char data_direction;
unsigned char pad[3];
compat_int_t quiet;
compat_int_t timeout;
compat_caddr_t reserved[1];
Expand Down

0 comments on commit 6d53a9f

Please sign in to comment.