Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Contributors to footer #68

Merged
merged 1 commit into from
Jun 19, 2019
Merged

Add Contributors to footer #68

merged 1 commit into from
Jun 19, 2019

Conversation

PandelisZ
Copy link
Member

I thought as there are people like @dr-o-ne and @FileJunkie doing a fantastic job of not only finding bugs but fixing them we'd credit them in the footer.

While in there I also noticed the version it spits out is 0.0.0 so made it spit out v3 at the very least and also thought it could do with a link to the actual source code.

It now looks like this:

Screenshot 2019-05-17 at 23 51 12

@d4nt
Copy link
Contributor

d4nt commented May 19, 2019

@PandelisZ I'm happy to give credit to contributors, but there's some settings in appveyor that adds the version number based on the build number (so 0.0.0.0 just means you're running from source). We do need to make that image labelling work on the docker image though and I haven't figured that out yet.

@PandelisZ
Copy link
Member Author

Gotcha will remove.

On the docker side. could run the docker publish on a git tag as the appveyor will tag it and then we could trigger a build from the tag: https://circleci.com/docs/2.0/workflows/#executing-workflows-for-a-git-tag

Added contributors link
Added link to source
@PandelisZ
Copy link
Member Author

I've split out the docker tagging discussion #69

@stale
Copy link

stale bot commented Jun 18, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jun 18, 2019
@d4nt d4nt removed the wontfix label Jun 19, 2019
@d4nt d4nt merged commit 2d6486e into develop Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants