Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support unmarshal custom type #127

Merged
merged 1 commit into from
Jul 19, 2022
Merged

Support unmarshal custom type #127

merged 1 commit into from
Jul 19, 2022

Conversation

XIELongDragon
Copy link
Contributor

Support unmarshal custom type which implements encoding.TextUnmarshaler interface

cristaloleg
cristaloleg previously approved these changes Jul 19, 2022
View reviewed changes
Copy link
Member

@cristaloleg cristaloleg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks!

@cristaloleg
Copy link
Member

Can you push a signed commit? (https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification)

@XIELongDragon
Copy link
Contributor Author

XIELongDragon commented Jul 19, 2022 •
edited
Loading

Can you push a signed commit? (https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification)

Hi @cristaloleg, just signed my commit

@cristaloleg cristaloleg merged commit 7766e43 into cristalhq:main Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristaloleg cristaloleg cristaloleg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@XIELongDragon @cristaloleg