Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add initial test setup #58

Merged
merged 5 commits into from
Aug 28, 2024
Merged

feat: add initial test setup #58

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
acd2a51
feat: add initial test setup
craftamap May 9, 2024
becb060
fix: reorder code adding attributes to tags
craftamap Aug 27, 2024
2349391
fix: use proper way to set absWorkingDir for esbuild
craftamap Aug 27, 2024
0f5251d
feat: add a bunch of unit tests
craftamap Aug 28, 2024
2f8f414
chore: update to node version 22
craftamap Aug 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: use proper way to set absWorkingDir for esbuild
  • Loading branch information
@craftamap
craftamap committed Aug 28, 2024
commit 234939136232bf92599f70e7eaac2e86e2f6eb3b
31 changes: 23 additions & 8 deletions test/e2e/index.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
import { describe, it, beforeEach, afterEach } from 'node:test'
import { htmlPlugin } from '../../lib/cjs/index.js'
import * as fsPromises from 'fs/promises'
import * as fs from 'fs'
import * as os from 'os'
import * as path from 'path'
import * as assert from 'assert'
import * as esbuild from 'esbuild'
const { htmlPlugin } = await import('../../lib/cjs/index.js')

describe('esbuild-plugin-html', () => {
let savedDir
Expand All @@ -17,13 +18,13 @@ describe('esbuild-plugin-html', () => {
process.chdir(savedDir)
})

const helper = async (htmlOptions) => {
const helper = async (/** @type {import('../../lib/cjs/index').HtmlFileConfiguration } */ htmlOptions) => {
await fsPromises.mkdir('src/')
await fsPromises.writeFile('src/index.ts', '')

// esbuild should default to the current cwd, but during import. using dynamic imports, we can avoid this.
const esbuild = await import('esbuild')
await esbuild.build({
// esbuild should default to the current cwd, but during import, so we need to specifcy a working directory here.
absWorkingDir: process.cwd(),
entryPoints: ['src/index.ts'],
metafile: true,
outdir: './out',
Expand All @@ -34,17 +35,16 @@ describe('esbuild-plugin-html', () => {
entryPoints: ['src/index.ts'],
...htmlOptions
},
]
],
})]
})


assert.ok(fs.existsSync('out/index.html'))
return await fsPromises.readFile('out/index.html', 'utf8')

}

it('creates a html file for a simple entry file', async () => {
it('creates html file with a script tag', async () => {

const result = await helper({})

Expand All @@ -59,7 +59,22 @@ describe('esbuild-plugin-html', () => {
})


it('creates a html file for a empty entry file', async () => {
it('creates html file containing the js inline', async () => {

const result = await helper({ inline: true })

assert.strictEqual(result, `<!DOCTYPE html><html><head>
<meta charset="utf-8">
</head>
<body>


<script></script></body></html>`
)
})


it('creates a html file for a empty template', async () => {

const result = await helper({
htmlTemplate: '',
Expand Down