Fix CMAKE_IOS_INSTALL_COMBINED on Xcode 12+ #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* According to https://gitlab.kitware.com/cmake/cmake/-/issues/21282 * Use cmake --install . rather than --build . --target install to avoid database is locked error.
hjmallon
force-pushed
the
_hm_ios_install_fix
branch
from
014a52b
to
8bd5d69
Compare
NeroBurner
approved these changes
Sep 7, 2022
|
Tested locally on Ubuntu 22.04 jammy with the Eigen example and everything still works as expected |
|
@rbsheth please merge this PR, the |
rbsheth
approved these changes
Sep 11, 2022
|
Now Xcode 14 is officially released, and it cannot work without this fix. Is it possible to release a new hunter version ASAP? Thanks. |
|
sure, released: https://github.com/cpp-pm/hunter/releases/tag/v0.24.7 |
|
@NeroBurner Wow, that's fast. Thank you so much. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://gitlab.kitware.com/cmake/cmake/-/issues/21282
Use cmake --install . rather than --build . --target install to avoid database is locked error.
I've checked this Git style guide. [Yes]
I've checked this CMake style guide. [Yes]
My change will work with CMake 3.2 (minimum requirement for Hunter). [Yes]
I will try to keep this pull request as small as possible and will try not to mix unrelated features. [Yes]