Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't upload cache if password is not set #454

Merged
merged 1 commit into from
Aug 9, 2021

Conversation

drodin
Copy link
Member

@drodin drodin commented Jul 28, 2021

  • I've checked this Git style guide. [Yes]
  • I've checked this CMake style guide. [Yes]
  • My change will work with CMake 3.2 (minimum requirement for Hunter). [Yes]
  • I will try to keep this pull request as small as possible and will try not to mix unrelated features. [Yes]

Helps to mitigate problem with manual workflow run in forked repo (as it's done on the master branch).
Without this change manual package test result in error:
[hunter ** FATAL ERROR **] Upload: PASSWORD is missing


@rbsheth rbsheth merged commit 13826ae into cpp-pm:master Aug 9, 2021
@rbsheth
Copy link
Member

rbsheth commented Aug 9, 2021

@drodin drodin deleted the pr.nocachewithoutpass branch November 26, 2021 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants