Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added NASM 2.13 #362

Merged
merged 8 commits into from
Mar 10, 2021
Merged

added NASM 2.13 #362

merged 8 commits into from
Mar 10, 2021

Conversation

neandreithal
Copy link

@neandreithal neandreithal commented Feb 15, 2021

  • I've followed this guide
    step by step carefully. [Yes]

Needed for libjpeg-turbo, according to this guide.

@rbsheth
Copy link
Member

rbsheth commented Feb 22, 2021

Still WIP?

@neandreithal neandreithal marked this pull request as ready for review February 28, 2021 12:50
@neandreithal
Copy link
Author

Sorry for the delay. This is a bit weird since half of the checks won't complete successfully even with the current default version.

@rbsheth
Copy link
Member

rbsheth commented Mar 1, 2021

Sorry for the delay. This is a bit weird since half of the checks won't complete successfully even with the current default version.

That's okay. We track which pass and fail here https://cpp-pm.github.io/hunter/ now so as long as it works for the main Linux, Windows, and Mac toolchains it is fine.

@neandreithal
Copy link
Author

That's okay. We track which pass and fail here https://cpp-pm.github.io/hunter/ now so as long as it works for the main Linux, Windows, and Mac toolchains it is fine.

Could you please elaborate on that? I don't see NASM package in the link you provided. Actually, is it compulsory to change the default version of the package?

@rbsheth
Copy link
Member

rbsheth commented Mar 10, 2021

That's okay. We track which pass and fail here https://cpp-pm.github.io/hunter/ now so as long as it works for the main Linux, Windows, and Mac toolchains it is fine.

Could you please elaborate on that? I don't see NASM package in the link you provided. Actually, is it compulsory to change the default version of the package?

Since it is a new page, it is only updated when an update/new package is added. It is generally compulsory to change the default version of a package if it is the newest.

@rbsheth rbsheth merged commit 7de453c into cpp-pm:master Mar 10, 2021
@rbsheth
Copy link
Member

rbsheth commented Mar 10, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants