Add libbacktrace package #174
Conversation
| # ) | ||
| #endif() | ||
|
|
||
| hunter_configuration_types(libbacktrace CONFIGURATION_TYPES Release) |
There was a problem hiding this comment.
Why hard code the configutation types. If debug is not supportet please add a comment about the reasons
There was a problem hiding this comment.
Because it uses the autotools scheme and this can only build one build type. If you remove this it will show an error:
[hunter ** FATAL ERROR **] Autotools PACKAGE_CONFIGURATION_TYPES has 2 elements: Release
[hunter ** FATAL ERROR **] Debug. Only 1 is allowed
[hunter ** FATAL ERROR **] [Directory:/source/hunter/_testing/Hunter/_Base/4ed7980/0fca6e7/2f6b703/Build/libbacktrace]
------------------------------ ERROR -----------------------------
https://hunter.readthedocs.io/en/latest/reference/errors/autools.package.configuration.types.html
------------------------------------------------------------------
CMake Error at /source/hunter/_testing/Hunter/_Base/Download/Hunter/unknown/4ed7980/Unpacked/cmake/modules/hunter_error_page.cmake:12 (message):
Call Stack (most recent call first):
/source/hunter/_testing/Hunter/_Base/Download/Hunter/unknown/4ed7980/Unpacked/cmake/modules/hunter_fatal_error.cmake:20 (hunter_error_page)
/source/hunter/_testing/Hunter/_Base/Download/Hunter/unknown/4ed7980/Unpacked/cmake/modules/hunter_autotools_configure_command.cmake:164 (hunter_fatal_error)
/source/hunter/_testing/Hunter/_Base/Download/Hunter/unknown/4ed7980/Unpacked/cmake/modules/hunter_autotools_project.cmake:158 (hunter_autotools_configure_command)
CMakeLists.txt:40 (hunter_autotools_project)
docs/packages/pkg/libbacktrace.rst
Outdated
| libbacktrace | ||
|
|
||
| .. index:: | ||
| single: unsorted ; libbacktrace |
There was a problem hiding this comment.
Can this be sorted into a category?
There was a problem hiding this comment.
Ok, I add Logging as category ....
| ) | ||
|
|
||
| if(WIN32) | ||
| set(CMAKE_FIND_LIBRARY_SUFFIXES ${_libbacktrace_ORIG_CMAKE_FIND_LIBRARY_SUFFIXES}) |
There was a problem hiding this comment.
Why is the variable reset again. Could you explain?
There was a problem hiding this comment.
It should be "reset" because other find_library() in other modules etc. shouldn't be affected ! See also FindBoost and other find modules. They all do it that way ... I added a comment.
| 7c7db4d096d96f329c453fb97b7a456fe823e943 | ||
| ) | ||
|
|
||
| #if (ANDROID OR IOS) |
There was a problem hiding this comment.
Arg, I always forget this ... thanks for the hint 👍 ... I removed it.
examples/libbacktrace/CMakeLists.txt
Outdated
| # * https://github.com/cpp-pm/gate | ||
| include("../common.cmake") | ||
|
|
||
| project(libbacktrace) |
There was a problem hiding this comment.
I think previous examples are called download-foo
in your case download-libbacktrace
I've followed this guide
step by step carefully. Yes
I've tested this package remotely and have excluded all broken builds.
Here is the links to the Travis/AppVeyor with status "All passed":
I have submitted CI configs to https://github.com/cpp-pm/hunter-testing targeting
pkg.templatebranch,see this merged pull request Testing for libbacktrace package hunter-testing#53