Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve the git hook script #5689

Merged
merged 8 commits into from
Feb 2, 2024

Conversation

levisyin
Copy link
Contributor

Description

This pr improves the pre-commit git hook.:

  1. Print install success message and path that the hook installed after we init the pre-commit git hook
  2. Fix duplicated issues reporting when multiple files are modified in the same directory

Motivation

When multiple files are modified in the same directory, the old pre-commit script will lint this directory multiple times, and report duplicate issues.

Commit Message / Changelog Entry

refactor: improve the git hook script

Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems sensible to me, dunno how much this is actually used atm tho! 😆

@crodriguezvega crodriguezvega merged commit 97a52e3 into cosmos:main Feb 2, 2024
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants