-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
post v7.1.0 release chores #3807
Conversation
@@ -1,5 +1,5 @@ | |||
{ | |||
"chain-a": ["release-v4.2.x", "v7.0.1", "v6.2.0", "v6.1.1", "v5.3.1", "v5.2.1", "v4.4.2", "v4.3.1", "v4.2.2", "v4.1.3"], | |||
"chain-a": ["release-v4.2.x", "v7.1.0", "v7.0.1", "v6.2.0", "v6.1.1", "v5.3.1", "v5.2.1", "v4.4.2", "v4.3.1", "v4.2.2", "v4.1.3"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file is has release-v4.1.x
but release-v4.2.x
is used in the json blob
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just one suggestion for a follow up PR
"v7.1.0", | ||
"v7.0.1", | ||
"v6.2.0", | ||
"v6.1.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
versions on separate lines make these diff reviews way easier, is it possible to format the other files so we can see the diffs this way? (I'd be happy with a follow up PR so as to not make this one more difficult to review!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does the trick locally (ran from the compatibility folder):
find . -name "*.json" -type f | while IFS= read -r json_file; do
jq '.' "$json_file" > temp.json && mv temp.json "$json_file"
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice @DimitrisJim, flexing your scripting muscles! 💪 Would you like to open a PR with those changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
easy peasy lemon squeezy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍋
Description
closes: #XXXX
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
).godoc
comments.Files changed
in the Github PR explorer.Codecov Report
in the comment section below once CI passes.