nit: allow arbitrary folder recursion for e2e tests. #3714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3714 +/- ##
==========================================
+ Coverage 78.74% 78.76% +0.02%
==========================================
Files 186 186
Lines 12816 12816
==========================================
+ Hits 10092 10095 +3
+ Misses 2291 2289 -2
+ Partials 433 432 -1 |
DimitrisJim
requested review from
colin-axner,
AdityaSripal,
crodriguezvega,
charleenfei,
damiannolan and
chatton
as code owners
DimitrisJim
commented
May 31, 2023
| @@ -50,10 +50,11 @@ jobs: | |||
| - name: Build e2e | |||
| run: | | |||
| cd e2e | |||
| test_dirs="$(ls -A tests)" | |||
| for td in $test_dirs | |||
| find ./tests -type d | while IFS= read -r dir | |||
There was a problem hiding this comment.
finds all folders in tests/ and if they contain a .go file, compiles the test binary
There was a problem hiding this comment.
So just so I understand this pipe - IFS = input field separator, and its separating on blank/space(?) reading from stdin into var dir which we then use inside the loop
There was a problem hiding this comment.
typically it is used with some separator value if required, setting it to nothing IFS= means it basically won't do any further splitting of the file paths (allowing e.g a path with spaces if one arises). A ref: https://unix.stackexchange.com/a/676870
chatton
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Something I noticed in #3710. In addition to that, doesn't seem like
03-connectiontests are currently checked during thebuildstep (though their tests are executed afterwards).closes: #XXXX
Commit Message / Changelog Entry
nit: allow arbitrary folder recursion for e2e tests.see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.