Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ica/controller)!: migrate ica/controller parameters to be self managed #3590

Merged
merged 65 commits into from
Jun 14, 2023
Merged
Changes from 1 commit
Commits
Show all changes
65 commits
Select commit Hold shift + click to select a range
d1a05d3
added the rpc endpoint and its messages
vishal-kanna May 16, 2023
c564407
ran make protogen command
vishal-kanna May 16, 2023
f42cf7b
implemented sdk.Msg for MsgUpdateParams in types/msgs.go
vishal-kanna May 16, 2023
caf4157
added NewMsgUpdateParams method in msgs.go
vishal-kanna May 16, 2023
0341872
added some functions in keeper and msg_Server
vishal-kanna May 16, 2023
5f1551e
changed ibc_middleware file
vishal-kanna May 16, 2023
3160787
changed the codec file
vishal-kanna May 16, 2023
4bd0992
used ibcerrors in msg_server
vishal-kanna May 16, 2023
fc51d0d
made changes in all the files
vishal-kanna May 17, 2023
d29830c
style(ica/controller): ran gofumpt
srdtrk May 29, 2023
a4344e2
imp(ica/controller): chnaged ParamsKey to string
srdtrk May 29, 2023
f4b11ea
imp(ica/controller): removed validate function as the parameter is ju…
srdtrk May 29, 2023
f322771
fix(ica/controller): fixed get/set functions based on new changes
srdtrk May 29, 2023
7bb0859
fix(ica/host): fixed errors caused by the recent changes
srdtrk May 29, 2023
1d419cc
style(ica/controller): ran gofumpt
srdtrk May 29, 2023
90c67fb
fix(ica/host): fixed golanci-lint errors
srdtrk May 29, 2023
9826355
docs(ica/host.proto): fixed comment on proto
srdtrk May 29, 2023
20a78ab
fix(ica/controller): naively removed legacySubspace from App
srdtrk May 29, 2023
f69c552
feat(ica/controller): added legacy subspace to keeper instead
srdtrk May 29, 2023
bd76911
fix(simapp): reduced the number of modifications due to recent changes
srdtrk May 29, 2023
f2f18ad
style(ica/controller): ran gofumpt
srdtrk May 29, 2023
f5b4d51
merge: remote-tracking branch 'origin' into ibcdev
srdtrk May 29, 2023
72c2374
fix(ica/controller): fixed merge conflict
srdtrk May 29, 2023
735d8a0
style(ica/controller): made panic message more consistent
srdtrk May 29, 2023
139e128
fix(ica): increased the migration version
srdtrk May 29, 2023
06d01b7
fix(ica): increased the migration version
srdtrk May 29, 2023
59b91bf
feat(ica/controller.test): added keeper params test
srdtrk May 29, 2023
3c76c6c
fix(ica.test): fixed test panic
srdtrk May 29, 2023
d73e215
feat(ica/controller.test): added test cases for MsgUpdateParams valid…
srdtrk May 29, 2023
6a4adac
feat(ica/controller.test): added test cases for UpdateParams rpc handler
srdtrk May 29, 2023
2c37ce9
imp(ica/controller.test): improved test cases for UpdateParams rpc ha…
srdtrk May 29, 2023
daae0f5
style(ica/controller.test): ran gofumpt
srdtrk May 29, 2023
15b127b
feat(ica/controller.test): added a new test called TestUnsetParams
srdtrk May 29, 2023
4d251c1
feat(ica/controller.test): added a new test case to TestMsgUpdatePara…
srdtrk May 29, 2023
ad08b5c
style(ica/controller.test): ran gofumpt
srdtrk May 29, 2023
a093252
docs(ica/controller): added tracker issue
srdtrk May 29, 2023
6e192ca
style(simapp): improved styling
srdtrk May 29, 2023
46a7a7e
docs: added migration info
srdtrk May 29, 2023
9142d70
docs(ica/controller): added godoc to UpdateParams
srdtrk May 29, 2023
bb8d19a
docs(ica/controller): fixed godocs
srdtrk May 29, 2023
6ac5d37
imp(ica/controller): improved err message
srdtrk May 29, 2023
357004d
imp(ica): combined the two param migrations
srdtrk May 29, 2023
c1d6dcf
style(ica/controller): changed the ordering of imports
srdtrk May 29, 2023
baa5ab3
feat(ica/controller.test): added a new test called TestGetAuthority t…
srdtrk May 29, 2023
4de882a
Merge branch 'main' into ibcdev
crodriguezvega May 29, 2023
689a2c9
fix(ica/controller.test): fixed a repeated test case
srdtrk May 30, 2023
799394d
style(ica/controller): used GetAuthority instead of k.authority
srdtrk May 30, 2023
0f3301c
fix(ica/controller): fixed error type
srdtrk May 30, 2023
cc55df8
style(ica/controller.proto): added missing space
srdtrk May 30, 2023
28aa75e
docs(ica/controller): fixed godoc typo
srdtrk May 30, 2023
227d501
style(ica/controller): used controllertypes alias
srdtrk May 30, 2023
ef1da4d
merge: remote-tracking branch 'origin' into ibcdev
srdtrk Jun 1, 2023
3ff156e
add comment
crodriguezvega Jun 2, 2023
74755f1
rename test
crodriguezvega Jun 2, 2023
860ede7
error message formatting
crodriguezvega Jun 2, 2023
19ce34b
merge: branch 'main' into ibcdev
srdtrk Jun 2, 2023
b80aa93
fix: ran proto-gen
srdtrk Jun 2, 2023
84c24e9
chore: added 'option (cosmos.msg.v1.signer) = authority;' to proto
srdtrk Jun 2, 2023
4f2cc18
imp: ran proto-gen
srdtrk Jun 2, 2023
1838d2b
merge: branch 'main' into ibcdev
srdtrk Jun 8, 2023
aac259f
fix(ica/controller): fixed migrations not checking nil keeper
srdtrk Jun 12, 2023
9991176
merge: branch 'main' into ibcdev
srdtrk Jun 12, 2023
018b6f6
merge: branch 'main' into ibcdev
srdtrk Jun 12, 2023
b38a5e3
merge: branch 'main' into ibcdev
srdtrk Jun 14, 2023
5a6aea0
style: removed nolint interfacer comment
srdtrk Jun 14, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat(ica/controller.test): added a new test case to TestMsgUpdatePara…
…msGetSigners
  • Loading branch information
srdtrk committed May 29, 2023
commit 4d251c1a6a550f14dac3fe2c48103ea319fb4bc0
Original file line number Diff line number Diff line change
Expand Up @@ -219,10 +219,26 @@ func TestMsgUpdateParamsValidation(t *testing.T) {

// TestMsgUpdateParamsGetSigners tests GetSigners for MsgUpdateParams
func TestMsgUpdateParamsGetSigners(t *testing.T) {
authority := sdk.AccAddress(ibctesting.TestAccAddress)
msg := types.MsgUpdateParams{
Authority: authority.String(),
Params: types.DefaultParams(),
testCases := []struct {
name string
address sdk.AccAddress
expPass bool
}{
{"success: valid address", sdk.AccAddress(ibctesting.TestAccAddress), true},
{"failure: nil address", nil, false},
}

for _, tc := range testCases {
msg := types.MsgUpdateParams{
Authority: tc.address.String(),
Params: types.DefaultParams(),
}
if tc.expPass {
require.Equal(t, []sdk.AccAddress{tc.address}, msg.GetSigners())
} else {
require.Panics(t, func() {
msg.GetSigners()
})
}
}
require.Equal(t, []sdk.AccAddress{authority}, msg.GetSigners())
}