Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add e2e go.mod to dependabot #3248

Merged
merged 3 commits into from
Mar 8, 2023
Merged

Conversation

colin-axner
Copy link
Contributor

@colin-axner colin-axner commented Mar 7, 2023

Description

I noticed dependabot updates to main never run go mod tidy in the e2e directory, I wonder if this would fix it or open 2 pr's?

closes: #XXXX

Commit Message / Changelog Entry

type: commit message

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@colin-axner
Copy link
Contributor Author

I think we should probably add this workflow https://github.com/cosmos/cosmos-sdk/blob/main/.github/workflows/dependabot-update-all.yml?

@damiannolan
Copy link
Member

I think we should probably add this workflow https://github.com/cosmos/cosmos-sdk/blob/main/.github/workflows/dependabot-update-all.yml?

Seems like probably a good idea considering we'll likely have more go mods

@colin-axner colin-axner enabled auto-merge (squash) March 8, 2023 16:42
@colin-axner colin-axner merged commit d002e18 into main Mar 8, 2023
@colin-axner colin-axner deleted the colin/dependabot-update branch March 8, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants