code hygiene: using host functions instead of constructing manually #3219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crodriguezvega
requested review from
colin-axner,
AdityaSripal and
damiannolan
as code owners
|
Looks like some tests are failing |
damiannolan
reviewed
Feb 28, 2023
Comment on lines
392
to
391
| clientPrefix := []byte(fmt.Sprintf("%s/%s/", host.KeyClientStorePrefix, clientID)) | ||
| clientPrefix := host.PrefixedClientStoreKey([]byte(clientID)) |
There was a problem hiding this comment.
seems like these are not quite the same, there's a trailing slash here but not in host.PrefixedClientStoreKey()
There was a problem hiding this comment.
Ahhh, yeah! I will revert then, but I wonder then why that trailing slash is needed there.. 🤔
There was a problem hiding this comment.
I'm not 100% as I didn't look super deep into it. I tried adding the trailing slash to PrefixedClientStorePath but had failing tests elsewhere.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3219 +/- ##
=======================================
Coverage 78.54% 78.54%
=======================================
Files 181 181
Lines 12580 12580
=======================================
Hits 9881 9881
Misses 2262 2262
Partials 437 437
|
colin-axner
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #XXXX
Commit Message / Changelog Entry
N/A
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.