Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit channel close event on ordered channel close (backport #1464) #1475

Merged
merged 2 commits into from
Jun 2, 2022

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 31, 2022

This is an automatic backport of pull request #1464 done by Mergify.
Cherry-pick of 9ed5ca4 has failed:

On branch mergify/bp/release/v3.0.x/pr-1464
Your branch is up to date with 'origin/release/v3.0.x'.

You are currently cherry-picking commit 9ed5ca4.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   modules/core/04-channel/keeper/events.go
	modified:   modules/core/04-channel/keeper/timeout.go
	modified:   modules/core/04-channel/types/events.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   CHANGELOG.md

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

(cherry picked from commit 9ed5ca4)

# Conflicts:
#	CHANGELOG.md
@crodriguezvega crodriguezvega merged commit 968d697 into release/v3.0.x Jun 2, 2022
@crodriguezvega crodriguezvega deleted the mergify/bp/release/v3.0.x/pr-1464 branch June 2, 2022 18:20
dudong2 pushed a commit to dudong2/ibc-go that referenced this pull request Jan 19, 2023
…) (cosmos#1475)

* Emit channel close event on ordered channel close (cosmos#1464)

(cherry picked from commit 9ed5ca4)

* fix conflict

Co-authored-by: Cian Hatton <[email protected]>
Co-authored-by: Carlos Rodriguez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants