Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use any as validator pubkey #7597

Merged
merged 58 commits into from
Oct 23, 2020
Merged

Use any as validator pubkey #7597

Changes from 1 commit
Commits
Show all changes
58 commits
Select commit Hold shift + click to select a range
e098384
protobuf pubkey type update
robert-zaremba Oct 19, 2020
4999b5c
wip2
robert-zaremba Oct 19, 2020
8f3645c
wip3
robert-zaremba Oct 19, 2020
bdd82af
solving types.NewValidator issues
robert-zaremba Oct 19, 2020
94047df
remove bech32 from validator type assignment
robert-zaremba Oct 19, 2020
324f31a
update Validator interface
robert-zaremba Oct 19, 2020
cc2d8a5
Changelog update
robert-zaremba Oct 19, 2020
774bf73
wip4
robert-zaremba Oct 19, 2020
ee2cad2
update genutil
robert-zaremba Oct 19, 2020
fc02eab
fix simapp & x/ibc/testing tests
clevinson Oct 19, 2020
51b2ab9
update staking
robert-zaremba Oct 19, 2020
05b8e73
changelog update
robert-zaremba Oct 19, 2020
3f139a1
fix import cycle in tests
robert-zaremba Oct 19, 2020
8734a4e
fix amino panic on TestValidatorMarshalUnmarshalJSON
robert-zaremba Oct 19, 2020
dfa92d6
fix TestValidatorMarshalUnmarshalJSON consensus_pubkey check
robert-zaremba Oct 19, 2020
32a2278
Add UnpackInterfaces to HistoricalInfo
robert-zaremba Oct 20, 2020
da990bf
fix TestHistoricalInfo
robert-zaremba Oct 20, 2020
003affd
update todos
robert-zaremba Oct 20, 2020
ff38afc
fix: Expecting ed25519.PubKey to implement proto.Message
robert-zaremba Oct 20, 2020
d50c77e
fix linter issues
robert-zaremba Oct 20, 2020
27ef9a7
Fix migrate test
amaury1093 Oct 20, 2020
4a95588
Update CHANGELOG.md
robert-zaremba Oct 20, 2020
98080ac
Merge pull request #7596 from cosmos/am-7477-migrate-staking
amaury1093 Oct 20, 2020
1dd1742
review comments
robert-zaremba Oct 20, 2020
515c072
cosmetic changes
robert-zaremba Oct 20, 2020
5cc8260
add UnpackInterfaces got GenesisRandomized test
robert-zaremba Oct 20, 2020
217bd2d
Validator.Equal reuses Validator.MinEqual
robert-zaremba Oct 20, 2020
605e33e
fix test
robert-zaremba Oct 20, 2020
d95c789
use Validator.Equal in tests
robert-zaremba Oct 20, 2020
5a07467
Fix staking simulation TestRandomizedGenState
blushi Oct 20, 2020
77f149f
Remove TODO
blushi Oct 20, 2020
1ac1245
use HistoricalInfo.Equal
robert-zaremba Oct 20, 2020
e6ac2ee
use proto.Equal
robert-zaremba Oct 20, 2020
da53a90
rename Validator.GetConsPubKey to TmConsPubKey
robert-zaremba Oct 20, 2020
978d9df
prefer require.Equal over reflect.DeepEqual
robert-zaremba Oct 20, 2020
653e4e4
SetHistoricalInfo using a pointer
robert-zaremba Oct 20, 2020
3da8daf
Fix TestQueryDelegation test
blushi Oct 21, 2020
34257ee
Fix TestQueryValidators test
blushi Oct 21, 2020
8905dfe
Fix TestSimulateMsgUnjail test
blushi Oct 21, 2020
fa73f01
experiement with LegacyAmino instances
robert-zaremba Oct 21, 2020
602928c
Register codecs in all simapp tests
robert-zaremba Oct 21, 2020
4774148
Fix cli_test compilation problems
robert-zaremba Oct 21, 2020
5350cc3
fix typo sdk -> std
robert-zaremba Oct 21, 2020
eddbe0c
fix typo
robert-zaremba Oct 21, 2020
62c1fc5
fix TestPlanStringer
robert-zaremba Oct 21, 2020
bfc93a3
Merge branch 'master' into robert/validator-pubkey
robert-zaremba Oct 21, 2020
a500f82
Rename to MakeEncodingConfig
amaury1093 Oct 22, 2020
6e33895
Remove RegisterCodecsTests
amaury1093 Oct 22, 2020
71e5331
Use gRPC in GetCmdQueryValidators
amaury1093 Oct 22, 2020
1cae118
Empty status
amaury1093 Oct 22, 2020
334253f
Merge pull request #7626 from cosmos/am-validator-pubkey
robert-zaremba Oct 22, 2020
54c85a5
fix info log check
robert-zaremba Oct 22, 2020
9d0ca25
linter fixes
robert-zaremba Oct 22, 2020
2598a7f
rename simapparams to simappparams
robert-zaremba Oct 23, 2020
4e21ba4
Update simapp/test_helpers.go
robert-zaremba Oct 23, 2020
a019c4d
comments updates
robert-zaremba Oct 23, 2020
1c8b045
use valAddr1 instead of sdk.ValAddress(pk1.Address().Bytes())
robert-zaremba Oct 23, 2020
1fa3829
Merge branch 'master' into robert/validator-pubkey
robert-zaremba Oct 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix migrate test
  • Loading branch information
@amaury1093
amaury1093 committed Oct 20, 2020
commit 27ef9a7b39f5de64f6d2730738758fa2aee65864
7 changes: 5 additions & 2 deletions x/staking/legacy/v040/migrate_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ func TestMigrate(t *testing.T) {
require.NoError(t, err)

// Make sure about:
// - consensus_pubkey: should be bech32 pubkey
// - consensus_pubkey: should be an any
// - validator's status should be 1 (new unbonded)
expected := `{
"delegations": [],
Expand All @@ -69,7 +69,10 @@ func TestMigrate(t *testing.T) {
},
"update_time": "0001-01-01T00:00:00Z"
},
"consensus_pubkey": "cosmosvalconspub1zcjduepq9ymett3nlv6fytn7lqxzd3q3ckvd79eqlcf3wkhgamcl4rzghesq83ecpx",
"consensus_pubkey": {
"@type": "/cosmos.crypto.ed25519.PubKey",
"key": "KTeVrjP7NJIufvgMJsQRxZjfFyD+Exda6O7x+oxIvmA="
},
"delegator_shares": "0",
"description": {
"details": "",
Expand Down