Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take empty input as yes answer #4565

Merged
merged 2 commits into from
Jun 16, 2019
Merged

Take empty input as yes answer #4565

merged 2 commits into from
Jun 16, 2019

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Jun 16, 2019 •
edited by alexanderbez
Loading

Closes: #4564

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

alexanderbez
alexanderbez approved these changes Jun 16, 2019
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

fedekunze
fedekunze approved these changes Jun 16, 2019
View reviewed changes
Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing clog but ACK

okwme
okwme approved these changes Jun 16, 2019
View reviewed changes
Copy link
Contributor

@okwme okwme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@alessio alessio merged commit 18415ee into master Jun 16, 2019
@alessio alessio deleted the alessio/confirmation-default-actio branch June 16, 2019 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@okwme okwme okwme approved these changes

@alexanderbez alexanderbez alexanderbez approved these changes

@fedekunze fedekunze fedekunze approved these changes

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

Assignees
No one assigned
Labels
C:CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cobra default action for (Y/n) doesn't work
4 participants
@alessio @okwme @alexanderbez @fedekunze