Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow splitting withdrawal txs #4384

Merged
merged 11 commits into from
May 23, 2019
Merged

allow splitting withdrawal txs #4384

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
59d537f
allow splitting withdrawal txs
jleni May 21, 2019
cec539e
updating .pending
jleni May 21, 2019
e1bc281
small cleanup
jleni May 21, 2019
c5e4088
fixing build issue
jleni May 21, 2019
767571c
Update x/distribution/client/cli/tx.go
jleni May 21, 2019
0e180b8
updating usage text
jleni May 21, 2019
59796b5
fixing merge issue
jleni May 21, 2019
a2d09ea
changes based on the review
jleni May 22, 2019
395a701
adding unit tests
jleni May 22, 2019
574071d
Update x/distribution/client/cli/tx.go
jleni May 22, 2019
bc65532
adjustments from review
jleni May 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
small cleanup
  • Loading branch information
@jleni
jleni committed May 21, 2019
commit e1bc2813f4c677e26193f892c77b6223d9f89f25
8 changes: 3 additions & 5 deletions x/distribution/client/cli/tx.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,6 @@ func GetTxCmd(storeKey string, cdc *amino.Codec) *cobra.Command {
}

func splitGenerateOrBroadcast(cliCtx context.CLIContext, txBldr authtxb.TxBuilder, msgs []sdk.Msg) error {
jleni marked this conversation as resolved.
Show resolved Hide resolved
var lastErr error = nil

chunkSize := viper.GetInt(flagMaxMessagesPerTx)
jleni marked this conversation as resolved.
Show resolved Hide resolved
totalMessages := len(msgs)
if chunkSize == 0 {
Expand All @@ -60,9 +58,9 @@ func splitGenerateOrBroadcast(cliCtx context.CLIContext, txBldr authtxb.TxBuilde
sliceEnd = totalMessages
}
msgChunk := msgs[i:sliceEnd]
lastErr = utils.GenerateOrBroadcastMsgs(cliCtx, txBldr, msgChunk)
if lastErr != nil {
return lastErr
err = utils.GenerateOrBroadcastMsgs(cliCtx, txBldr, msgChunk)
if err != nil {
return err
}
}

Expand Down