Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Fix query distr slashes #3419

Merged
merged 2 commits into from
Jan 29, 2019
Merged

R4R: Fix query distr slashes #3419

merged 2 commits into from
Jan 29, 2019

Conversation

jackzampolin
Copy link
Member

Fixes #3391

  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

@codecov
Copy link

codecov bot commented Jan 28, 2019

Codecov Report

Merging #3419 into develop will decrease coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #3419      +/-   ##
===========================================
- Coverage    59.22%   59.18%   -0.05%     
===========================================
  Files          132      132              
  Lines         9900     9900              
===========================================
- Hits          5863     5859       -4     
- Misses        3665     3669       +4     
  Partials       372      372

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is what we want, see comment - also needs PENDING.md if we do want this.

@cwgoes cwgoes merged commit 6de39e1 into develop Jan 29, 2019
@cwgoes cwgoes deleted the jack/dist-fix branch January 29, 2019 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants