Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Cmds for validator unbondings and redelegations #2569

Merged
merged 14 commits into from
Oct 28, 2018

Conversation

fedekunze
Copy link
Collaborator

@fedekunze fedekunze commented Oct 23, 2018

Closes #2566


  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Oct 23, 2018

Codecov Report

Merging #2569 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #2569   +/-   ##
========================================
  Coverage    58.81%   58.81%           
========================================
  Files          152      152           
  Lines         9420     9420           
========================================
  Hits          5540     5540           
  Misses        3510     3510           
  Partials       370      370

@fedekunze fedekunze changed the title WIP: Cmds for validator unbondings and redelegations R4R: Cmds for validator unbondings and redelegations Oct 23, 2018
x/stake/client/cli/query.go Show resolved Hide resolved
x/stake/client/cli/query.go Show resolved Hide resolved
x/stake/client/cli/query.go Outdated Show resolved Hide resolved
x/stake/client/cli/query.go Show resolved Hide resolved
x/stake/client/cli/query.go Outdated Show resolved Hide resolved
@fedekunze
Copy link
Collaborator Author

fedekunze commented Oct 24, 2018

@cwgoes @alexanderbez The option to optionally indent the response needs to be done on most cmds (not only on these ones). I need to update the queriers to be able to do that as well. I'll tackle that on #2582

@fedekunze
Copy link
Collaborator Author

@alexanderbez @cwgoes @jackzampolin this should be ready for a final review and merge

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, 🌵

@cwgoes cwgoes merged commit 855e0ac into develop Oct 28, 2018
@cwgoes cwgoes deleted the fedekunze/2566-cmds-validator-ubds-reds branch October 28, 2018 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants