R4R: Distr-PR-1 Staking ConsPubKey -> ConsAddr index

[rigelrozanski]

splitting up the distribution PRs cause there's a lot.

closes #2244
ref #2369
Note this PR also deletes old distribution (commented-out) code

• Targeted PR against correct branch (see CONTRIBUTING.md)
• Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
• Wrote tests
• Updated relevant documentation (docs/)
• Added entries in PENDING.md with issue #
• rereviewed Files changed in the github PR explorer

---

For Admin Use:

• Added appropriate labels to PR (ex. wip, ready-for-review, docs)
• Reviewers Assigned
• Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

[rigelrozanski]

I tried to keep the refactors to a minimum in this PR but there are some basic ones which I just left in (copied from fee-distribution PR)

[ValarDragon]

utACK

I agree with all of the refactors done here, I think they really cleanup the code. (Especially migrating more of the code to use address instead of pubkey, I think thats been needed for awhile now) Thanks Rigel!

[codecov]

Codecov Report

Merging #2369 into develop will increase coverage by 2.84%.
The diff coverage is 67.46%.

@@             Coverage Diff             @@
##           develop    #2369      +/-   ##
===========================================
+ Coverage    61.94%   64.78%   +2.84%     
===========================================
  Files          132      135       +3     
  Lines         8245     8442     +197     
===========================================
+ Hits          5107     5469     +362     
+ Misses        2811     2602     -209     
- Partials       327      371      +44

[cwgoes]

Looks great, I think we can simplify just a bit further.

[alexanderbez]

LGTM -- Agree with @cwgoes comment and your suggestion in creating a helper function to get rid of ValidatorByConsPubKey.

addressed