Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set correct checksums after adding multiarch support #22102

Merged

Conversation

troian
Copy link
Contributor

@troian troian commented Oct 3, 2024

fixes #21911 #21933

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

  • New Features

    • Updated binary checksum values for the "chain2" upgrade.
    • Changed the format of the binary download links to a single URL for easier access to download instructions.
  • Bug Fixes

    • Corrected checksum values for binaries to reflect the latest updates.

Copy link
Contributor

coderabbitai bot commented Oct 3, 2024

📝 Walkthrough
📝 Walkthrough

Walkthrough

The changes involve modifications to the JSON structure in scripts related to the Cosmovisor tool, specifically for the "chain2" upgrade. The info field has been updated to reflect new checksum values for various binaries and altered URLs pointing to updated binary files. Additionally, the format of the info field has changed to provide a single URL for download instructions instead of multiple binary links. The overall structure and logic of the scripts remain unchanged.

Changes

File Path Change Summary
tools/cosmovisor/testdata/download/cosmovisor/genesis/bin/autod Updated JSON structure with new checksum values for binaries and modified URLs for binaries.
tools/cosmovisor/testdata/repo/chain2-zip_bin/autod Changed info field format from multiple binary links to a single URL string for download instructions.

Assessment against linked issues

Objective Addressed Explanation
Add multiarch bin references (#[21911])

Possibly related PRs

Suggested labels

backport/v0.52.x

Suggested reviewers

  • facundomedica
  • julienrbrt
  • tac0turtle

📜 Recent review details

Configuration used: .coderabbit.yml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between f9ef8f0 and 452e280.

⛔ Files ignored due to path filters (1)
  • tools/cosmovisor/testdata/repo/chain2-zip_bin/autod.zip is excluded by !**/*.zip
📒 Files selected for processing (2)
  • tools/cosmovisor/testdata/download/cosmovisor/genesis/bin/autod (1 hunks)
  • tools/cosmovisor/testdata/repo/chain2-zip_bin/autod (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • tools/cosmovisor/testdata/download/cosmovisor/genesis/bin/autod
  • tools/cosmovisor/testdata/repo/chain2-zip_bin/autod

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the C:Cosmovisor Issues and PR related to Cosmovisor label Oct 3, 2024
@troian troian force-pushed the cosmovisor-testdata-checksums branch from f9ef8f0 to 452e280 Compare October 3, 2024 13:47
@julienrbrt julienrbrt added this pull request to the merge queue Oct 4, 2024
Merged via the queue into cosmos:main with commit eec7392 Oct 4, 2024
71 of 73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Cosmovisor Issues and PR related to Cosmovisor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants