fix: Bump CometBFT versions #20481
Merged
fix: Bump CometBFT versions #20481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughWalkthroughThe changes involve two main updates: uncommenting and adjusting the indentation of a block in the Changes
Sequence Diagram(s) (Beta)No sequence diagrams are provided as the changes are related to test configurations and minor test function modifications, which do not significantly alter control flow or introduce new features. Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
github-actions
bot
added
C:x/staking
C:CLI
C:x/gov
C:x/slashing
C:x/distribution
alpe
changed the title
|
@alpe your pull request is missing a changelog! |
|
Does this need a changelog? It bumps to an untagged version. 😨 |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files ignored due to path filters (48)
client/v2/go.modis excluded by!**/*.modclient/v2/go.sumis excluded by!**/*.sumgo.modis excluded by!**/*.modgo.sumis excluded by!**/*.sumsimapp/go.modis excluded by!**/*.modsimapp/go.sumis excluded by!**/*.sumtests/go.modis excluded by!**/*.modtests/go.sumis excluded by!**/*.sumx/accounts/defaults/lockup/go.modis excluded by!**/*.modx/accounts/defaults/lockup/go.sumis excluded by!**/*.sumx/accounts/go.modis excluded by!**/*.modx/accounts/go.sumis excluded by!**/*.sumx/auth/go.modis excluded by!**/*.modx/auth/go.sumis excluded by!**/*.sumx/authz/go.modis excluded by!**/*.modx/authz/go.sumis excluded by!**/*.sumx/bank/go.modis excluded by!**/*.modx/bank/go.sumis excluded by!**/*.sumx/circuit/go.modis excluded by!**/*.modx/circuit/go.sumis excluded by!**/*.sumx/consensus/go.modis excluded by!**/*.modx/consensus/go.sumis excluded by!**/*.sumx/distribution/go.modis excluded by!**/*.modx/distribution/go.sumis excluded by!**/*.sumx/epochs/go.modis excluded by!**/*.modx/epochs/go.sumis excluded by!**/*.sumx/evidence/go.modis excluded by!**/*.modx/evidence/go.sumis excluded by!**/*.sumx/feegrant/go.modis excluded by!**/*.modx/feegrant/go.sumis excluded by!**/*.sumx/gov/go.modis excluded by!**/*.modx/gov/go.sumis excluded by!**/*.sumx/group/go.modis excluded by!**/*.modx/group/go.sumis excluded by!**/*.sumx/mint/go.modis excluded by!**/*.modx/mint/go.sumis excluded by!**/*.sumx/nft/go.modis excluded by!**/*.modx/nft/go.sumis excluded by!**/*.sumx/params/go.modis excluded by!**/*.modx/params/go.sumis excluded by!**/*.sumx/protocolpool/go.modis excluded by!**/*.modx/protocolpool/go.sumis excluded by!**/*.sumx/slashing/go.modis excluded by!**/*.modx/slashing/go.sumis excluded by!**/*.sumx/staking/go.modis excluded by!**/*.modx/staking/go.sumis excluded by!**/*.sumx/upgrade/go.modis excluded by!**/*.modx/upgrade/go.sumis excluded by!**/*.sum
Files selected for processing (2)
- .github/workflows/test.yml (1 hunks)
- tests/systemtests/upgrade_test.go (1 hunks)
Files skipped from review due to trivial changes (2)
- .github/workflows/test.yml
- tests/systemtests/upgrade_test.go
|
It doesn't. The bot only looks at the PR prefix, and fixes usually need a changelog. |
julienrbrt
approved these changes
May 30, 2024
sontrinh16
approved these changes
May 30, 2024
tac0turtle
approved these changes
May 30, 2024
alpe
added a commit
that referenced
this pull request
May 31, 2024
* main: feat(server/v2): introduce cometbft v2 (#20483) refactor(x/upgrade): migrate to appmodule.VersionMap (#20485) docs: code guidelines changes (#20482) feat(cosmovisor): load cosmovisor configuration from toml file (#19995) perf(math): Significantly speedup Dec quo truncate and quo Roundup (#20034) fix: Bump CometBFT versions (#20481)
alpe
added a commit
that referenced
this pull request
May 31, 2024
* main: (120 commits) chore: update protoc-gen-swagger to protoc-gen-openapiv2 (#20448) ci: Add GitHub Action for go mod tidy and mocks (#20501) chore: Address linter issues (#20486) fix: wrap errors in auto CLI service registration (#20493) chore: fix comment (#20498) chore: fix the note box syntax error (#20499) feat(server/v2): introduce cometbft v2 (#20483) refactor(x/upgrade): migrate to appmodule.VersionMap (#20485) docs: code guidelines changes (#20482) feat(cosmovisor): load cosmovisor configuration from toml file (#19995) perf(math): Significantly speedup Dec quo truncate and quo Roundup (#20034) fix: Bump CometBFT versions (#20481) refactor(core): remove redundant ExecMode (#20322) feat(store/v2): pruning manager (#20430) chore: force reload sonar cloud (#20480) refactor(x/accounts): reuse calculated sum in `func safeAdd` (#20458) refactor: remove `defer` in loop (#20223) ci: remove livness test (#20474) build(deps): Bump bufbuild/buf-setup-action from 1.32.1 to 1.32.2 (#20477) chore: migrate a few diagrams to mermaid (#20473) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #20318
Bump CometBFT in go mods
This includes the chain upgrade test activation
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit