perf: Don't deserialize params for every validator in slashing

[ValarDragon]

Description

Pretty light performance improvement. Its a been a consistent small point that validators missed block tracking appears in CPU profiles. (DB key format / data layout is the bigger issue to fixing)

This at least removes the param deserialization of it. I don't have a "fair" benchmark to compare with on-hand over a large period, but on an IAVL v0 benchmark during 100 blocks with high CPU load, it appears params deserialziation is taking .8% of the CPU time for block execution.

Go tests are broken on my laptop rn for the SDK, hopefully this works without too many back + forths 🙏
I won't be able to fix too many follow-ups in a hot loop because of this, so happy to close if its not worth the overhead. (Or have someone else take over!)

This should be fully state compatible.

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• reviewed "Files changed" and left comments if necessary
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• updated the relevant documentation or specification, including comments for documenting Go code
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed all author checklist items have been addressed
• reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

[coderabbitai]

Walkthrough

The changes involve updates to the slashing module, specifically refining how the BeginBlocker function processes validator activities and the calculation of the minimum number of blocks validators must sign. The logic for slashing and unbonding due to missed blocks has been adjusted, and a new method for calculating the MinSignedPerWindow parameter has been implemented to ensure it's derived from existing struct fields and rounded to the nearest integer.

Changes

Files	Summary
x/slashing/abci.go	Updated BeginBlocker function to retrieve parameters and handle validator signatures with additional parameters, potentially affecting the logic related to slashing and unbonding validators based on missed blocks, introducing a slight speedup to the Slashing Beginblock logic.
x/slashing/keeper/infractions.go, x/slashing/keeper/params.go, x/slashing/types/params.go	Modified HandleValidatorSignature function in infractions.go to call a new HandleValidatorSignatureWithParams function with additional parameters. The new function takes a types.Params object as an argument and uses its fields for computation. Additionally, in keeper/params.go, the MinSignedPerWindow function has been modified to now call another function MinSignedPerWindowInt on the receiver params instead of directly using the params struct fields SignedBlocksWindow and MinSignedPerWindow. Also, the MinSignedPerWindow method has been added to the Params type, which calculates a value based on the SignedBlocksWindow and MinSignedPerWindow fields and returns the result rounded to the nearest integer.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit's AI:

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your comments unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid.
  • @coderabbitai read the files in the src/scheduler package and generate README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[julienrbrt]

lgtm!

[julienrbrt]

Minor nit, changelog of modules should be under their own changelog.
Here x/slashing/changelog.md

[ValarDragon]

Ah thank you will move that

[julienrbrt]

Nit go doc naming.

[alexanderbez]

utACK

[tac0turtle]

Thanks for the pr