Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(x/gov): invert & simplify EndBlocker conditions for expedited proposals #16850

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

odeke-em
Copy link
Collaborator

@odeke-em odeke-em commented Jul 6, 2023

…posals

Inverts the condtion for updating deposits for either failing or unexpedited proposals to make it simpler to read and maintain for the future.

Fixes #16807

@odeke-em odeke-em requested a review from a team as a code owner July 6, 2023 06:37
@odeke-em
Copy link
Collaborator Author

odeke-em commented Jul 6, 2023

/cc @elias-orijtech

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

@odeke-em your pull request is missing a changelog!

…posals

Inverts the condtion for updating deposits for either failing or unexpedited
proposals to make it simpler to read and maintain for the future.

Fixes #16807
@odeke-em odeke-em force-pushed the x-gov-simplify-EndBlocker-condition branch from 61fee74 to 2efb2b3 Compare July 6, 2023 06:43
@julienrbrt julienrbrt changed the title fix: x/gov: invert & simplify EndBlocker conditions for expedited pro… style(x/gov) invert & simplify EndBlocker conditions for expedited proposals Jul 6, 2023
@julienrbrt julienrbrt changed the title style(x/gov) invert & simplify EndBlocker conditions for expedited proposals style(x/gov): invert & simplify EndBlocker conditions for expedited proposals Jul 6, 2023
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense!

@odeke-em odeke-em added this pull request to the merge queue Jul 6, 2023
Merged via the queue into main with commit 101992a Jul 6, 2023
54 checks passed
@odeke-em odeke-em deleted the x-gov-simplify-EndBlocker-condition branch July 6, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

audit: invert conditions in x/gov in EndBlocker for clarity in reading and later bug fixing
2 participants