Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Make CacheKV store interleaved iterator and insertion not O(n^2) (backport #10026) #10167

Merged
merged 4 commits into from
Sep 16, 2021

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 16, 2021

This is an automatic backport of pull request #10026 done by Mergify.
Cherry-pick of 28bf2c1 has failed:

On branch mergify/bp/release/v0.44.x/pr-10026
Your branch is up to date with 'origin/release/v0.44.x'.

You are currently cherry-picking commit 28bf2c124.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   store/cachekv/memiterator.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   CHANGELOG.md
	both modified:   store/cachekv/store.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.io/

#10026)

(cherry picked from commit 28bf2c1)

# Conflicts:
#	CHANGELOG.md
#	store/cachekv/store.go
@orijbot
Copy link

orijbot commented Sep 16, 2021

@lgtm-com
Copy link

lgtm-com bot commented Sep 16, 2021

This pull request introduces 3 alerts when merging c2bf99b into 000c17b - view on LGTM.com

new alerts:

  • 2 for Unreachable statement
  • 1 for Expression has no effect

@lgtm-com
Copy link

lgtm-com bot commented Sep 16, 2021

This pull request introduces 3 alerts when merging 2fbb4d6 into 000c17b - view on LGTM.com

new alerts:

  • 2 for Unreachable statement
  • 1 for Expression has no effect

@lgtm-com
Copy link

lgtm-com bot commented Sep 16, 2021

This pull request introduces 3 alerts when merging 6a3a7d8 into cbc164a - view on LGTM.com

new alerts:

  • 2 for Unreachable statement
  • 1 for Expression has no effect

@robert-zaremba robert-zaremba merged commit 22a4f50 into release/v0.44.x Sep 16, 2021
@robert-zaremba robert-zaremba deleted the mergify/bp/release/v0.44.x/pr-10026 branch September 16, 2021 23:22
@amaury1093 amaury1093 added this to the v0.44.1 milestone Sep 29, 2021
evan-forbes pushed a commit to evan-forbes/cosmos-sdk that referenced this pull request Oct 12, 2021
…) (backport cosmos#10026) (cosmos#10167)

* perf: Make CacheKV store interleaved iterator and insertion not O(n^2) (cosmos#10026)

(cherry picked from commit 28bf2c1)

# Conflicts:
#	CHANGELOG.md
#	store/cachekv/store.go

* fix changelog conflict

* Update store.go

Co-authored-by: Dev Ojha <[email protected]>
Co-authored-by: Robert Zaremba <[email protected]>
evan-forbes pushed a commit to evan-forbes/cosmos-sdk that referenced this pull request Nov 1, 2021
…) (backport cosmos#10026) (cosmos#10167)

* perf: Make CacheKV store interleaved iterator and insertion not O(n^2) (cosmos#10026)

(cherry picked from commit 28bf2c1)

# Conflicts:
#	CHANGELOG.md
#	store/cachekv/store.go

* fix changelog conflict

* Update store.go

Co-authored-by: Dev Ojha <[email protected]>
Co-authored-by: Robert Zaremba <[email protected]>
Eengineer1 pushed a commit to cheqd/cosmos-sdk that referenced this pull request Aug 26, 2022
…) (backport cosmos#10026) (cosmos#10167)

* perf: Make CacheKV store interleaved iterator and insertion not O(n^2) (cosmos#10026)

(cherry picked from commit 28bf2c1)

* fix changelog conflict

* Update store.go

Co-authored-by: Dev Ojha <[email protected]>
Co-authored-by: Robert Zaremba <[email protected]>
JeancarloBarrios pushed a commit to agoric-labs/cosmos-sdk that referenced this pull request Sep 28, 2024
…) (backport cosmos#10026) (cosmos#10167)

* perf: Make CacheKV store interleaved iterator and insertion not O(n^2) (cosmos#10026)

(cherry picked from commit 28bf2c1)

# Conflicts:
#	CHANGELOG.md
#	store/cachekv/store.go

* fix changelog conflict

* Update store.go

Co-authored-by: Dev Ojha <[email protected]>
Co-authored-by: Robert Zaremba <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants