BlockGasMeter panics when using CheckTx mode

[fedekunze]

Summary of Bug

The BlockGasMeter is only available for the deliverState context (i.e when running txs in DeliverTx mode). Any call to retrieve the block gas consumed or limit will panic during (Re)CheckTx. Ref:

cosmos-sdk/baseapp/abci.go

Lines 171 to 179 in 179c819

	// add block gas meter
	var gasMeter sdk.GasMeter
	if maxGas := app.getMaximumBlockGas(app.deliverState.ctx); maxGas > 0 {
	gasMeter = sdk.NewGasMeter(maxGas)
	} else {
	gasMeter = sdk.NewInfiniteGasMeter()
	}
	app.deliverState.ctx = app.deliverState.ctx.WithBlockGasMeter(gasMeter)

cosmos-sdk/baseapp/baseapp.go

Lines 525 to 527 in 179c819

	// retrieve the context for the tx w/ txBytes and other memoized values.
	func (app *BaseApp) getContextForTx(mode runTxMode, txBytes []byte) sdk.Context {
	ctx := app.getState(mode).ctx.

cosmos-sdk/baseapp/baseapp.go

Lines 515 to 523 in 179c819

	// Returns the applications's deliverState if app is in runTxModeDeliver,
	// otherwise it returns the application's checkstate.
	func (app *BaseApp) getState(mode runTxMode) *state {
	if mode == runTxModeDeliver {
	return app.deliverState
	}
	return app.checkState
	}

The block gas meter should be available to both checkTx and deliverTx state contexts

Original issue: evmos/ethermint#119
Credits to @thomas-nguy

Version

v0.42.5

Steps to Reproduce

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[ethanfrey]

Good find. This would be a good bug fix.