Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: version commands should give more info, but sometimes less info #1894

Closed
ebuchman opened this issue Jul 31, 2018 · 6 comments · Fixed by #3436
Closed

cmd: version commands should give more info, but sometimes less info #1894

ebuchman opened this issue Jul 31, 2018 · 6 comments · Fixed by #3436

Comments

@ebuchman
Copy link
Member

ebuchman commented Jul 31, 2018

Version command should include more information:

  • OS info and version
  • Golang version
  • SDK commit hash
  • Vendor dir hash

Reason for the vendor dir hash is the git commit hash doesn't tell us if the binary was compiled with the right dependencies.

An alternative way to solve this vendor-dir-hash element that maybe we should start to consider is checking in the vendor directory.

@alexanderbez
Copy link
Contributor

Neat! I don't necessarily think we should commit vendor/ in. I think the hash is fine idea.

@cwgoes
Copy link
Contributor

cwgoes commented Jan 16, 2019

cc @alessio Thoughts on this?

@alessio
Copy link
Contributor

alessio commented Jan 17, 2019

Reasonable - although a bit unsure about vendor/ hashing. We should ship the vendor dir along with our release tarballs. I can work on this

alessio pushed a commit that referenced this issue Jan 22, 2019
@mdyring
Copy link

mdyring commented Jan 27, 2019

Could we re-introduce a short output version of this? (perhaps using a --short flag)

We're using it to label (and tag) cloud instances like "${GAIA_VERSION} / ${CHAIN_ID} / ..." so would be nice to keep this capability.

A picture is worth a 1000 words :-)

image

@mdyring
Copy link

mdyring commented Jan 27, 2019

.. alternatively, as suggested by @jackzampolin introduce a --output json option so this is easier to extract.

@alessio
Copy link
Contributor

alessio commented Jan 27, 2019

I saw this coming. My fault, I shouldn't have break this ABI in the first place.
I will amend version command to: 1. show by default a short string 2. show extended info if --long flag is passed 3. implement JSON formatting

@alessio alessio reopened this Jan 27, 2019
@jackzampolin jackzampolin added this to the v0.31.0 (Launch RC) milestone Jan 29, 2019
@cwgoes cwgoes changed the title cmd: version commands should give more info cmd: version commands should give more info, but sometimes less info Jan 29, 2019
alessio pushed a commit that referenced this issue Jan 29, 2019
Handle -o json, add --long flag to print full version info.

Closes: #1894
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment