-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(stf/router): support backwards compat type URL in router (#21177)
- Loading branch information
1 parent
90fd632
commit 4dc9469
Showing
3 changed files
with
160 additions
and
18 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,107 @@ | ||
package stf | ||
|
||
import ( | ||
"context" | ||
"testing" | ||
|
||
gogoproto "github.com/cosmos/gogoproto/proto" | ||
gogotypes "github.com/cosmos/gogoproto/types" | ||
"github.com/stretchr/testify/assert" | ||
"github.com/stretchr/testify/require" | ||
|
||
"cosmossdk.io/core/appmodule/v2" | ||
) | ||
|
||
func TestRouter(t *testing.T) { | ||
expectedMsg := &gogotypes.BoolValue{Value: true} | ||
expectedMsgName := gogoproto.MessageName(expectedMsg) | ||
|
||
expectedResp := &gogotypes.StringValue{Value: "test"} | ||
|
||
router := coreRouterImpl{handlers: map[string]appmodule.Handler{ | ||
gogoproto.MessageName(expectedMsg): func(ctx context.Context, gotMsg appmodule.Message) (msgResp appmodule.Message, err error) { | ||
require.Equal(t, expectedMsg, gotMsg) | ||
return expectedResp, nil | ||
}, | ||
}} | ||
|
||
t.Run("can invoke message by name", func(t *testing.T) { | ||
err := router.CanInvoke(context.Background(), expectedMsgName) | ||
require.NoError(t, err, "must be invokable") | ||
}) | ||
|
||
t.Run("can invoke message by type URL", func(t *testing.T) { | ||
err := router.CanInvoke(context.Background(), "/"+expectedMsgName) | ||
require.NoError(t, err) | ||
}) | ||
|
||
t.Run("cannot invoke unknown message", func(t *testing.T) { | ||
err := router.CanInvoke(context.Background(), "not exist") | ||
require.Error(t, err) | ||
}) | ||
|
||
t.Run("invoke untyped", func(t *testing.T) { | ||
gotResp, err := router.InvokeUntyped(context.Background(), expectedMsg) | ||
require.NoError(t, err) | ||
require.Equal(t, expectedResp, gotResp) | ||
}) | ||
|
||
t.Run("invoked typed", func(t *testing.T) { | ||
gotResp := new(gogotypes.StringValue) | ||
err := router.InvokeTyped(context.Background(), expectedMsg, gotResp) | ||
require.NoError(t, err) | ||
require.Equal(t, expectedResp, gotResp) | ||
}) | ||
} | ||
|
||
func TestMerge(t *testing.T) { | ||
tests := []struct { | ||
name string | ||
src gogoproto.Message | ||
dst gogoproto.Message | ||
expected gogoproto.Message | ||
wantErr bool | ||
}{ | ||
{ | ||
name: "success", | ||
src: &gogotypes.BoolValue{Value: true}, | ||
dst: &gogotypes.BoolValue{}, | ||
expected: &gogotypes.BoolValue{Value: true}, | ||
wantErr: false, | ||
}, | ||
{ | ||
name: "nil src", | ||
src: nil, | ||
dst: &gogotypes.StringValue{}, | ||
expected: &gogotypes.StringValue{}, | ||
wantErr: true, | ||
}, | ||
{ | ||
name: "nil dst", | ||
src: &gogotypes.StringValue{Value: "hello"}, | ||
dst: nil, | ||
expected: nil, | ||
wantErr: true, | ||
}, | ||
{ | ||
name: "incompatible types", | ||
src: &gogotypes.StringValue{Value: "hello"}, | ||
dst: &gogotypes.BoolValue{}, | ||
expected: &gogotypes.BoolValue{}, | ||
wantErr: true, | ||
}, | ||
} | ||
|
||
for _, tt := range tests { | ||
t.Run(tt.name, func(t *testing.T) { | ||
err := merge(tt.src, tt.dst) | ||
|
||
if tt.wantErr { | ||
assert.Error(t, err) | ||
} else { | ||
assert.NoError(t, err) | ||
assert.Equal(t, tt.expected, tt.dst) | ||
} | ||
}) | ||
} | ||
} |