-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade packages #634
Upgrade packages #634
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good, let me try to pull it later and test the branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked this out locally
Note the |
@kwelch I think its because of a new commit I pushed |
Any updates on this PR? |
I think we need @coryhouse since appveyor did not report back properly and I am unable to merge this. |
Yeah, I wonder why AppVeyor always hangs. 🤔 |
Works great for me! Thanks for your help! I'm going to merge as is - Appveyor has been failing for awhile for unrelated reasons that I'll dig into separately. |
Thanks Cory! |
Pull Request Template
The code review checklist below is used for all pull requests.
Checklist
npm run build
)Thanks!
❤️