Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade packages #634

Merged
merged 4 commits into from
Oct 31, 2019
Merged

Upgrade packages #634

merged 4 commits into from
Oct 31, 2019

Conversation

arunmmanoharan
Copy link
Contributor

@arunmmanoharan arunmmanoharan commented Oct 12, 2019

Pull Request Template

The code review checklist below is used for all pull requests.

  1. Review the list before submitting your pull request.
  2. Leave the list intact for the code reviewer's use.

Checklist

  • Latest code from master has been merged into the pull request branch
  • Honors the seven code virtues
    • Working, as opposed to incomplete
    • Unique, as opposed to duplicated
    • Simple, as opposed to complicated
    • Clear, as opposed to puzzling
    • Easy, as opposed to difficult
    • Developed, as opposed to primitive
    • Brief, as opposed to chatty
  • Code is camelCased
  • No commented out code (if required, place // TODO above with explanation)
  • No linting issues
  • Automated tests exist and pass
  • Build is successful (npm run build)
  • Works in IE 11, Chrome, Firefox, and Edge

Thanks!

❤️

@coveralls
Copy link

coveralls commented Oct 12, 2019

Coverage Status

Coverage remained the same at 91.525% when pulling 25e705a on a2441918:master into 4950597 on coryhouse:master.

webpack.config.prod.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@kwelch kwelch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, let me try to pull it later and test the branch.

Copy link
Collaborator

@kwelch kwelch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked this out locally

@kwelch
Copy link
Collaborator

kwelch commented Oct 18, 2019

Note the package.json had an update when I ran it locally. I am never sure is that is expected.

@arunmmanoharan
Copy link
Contributor Author

@kwelch I think its because of a new commit I pushed

@arunmmanoharan
Copy link
Contributor Author

Any updates on this PR?

@kwelch
Copy link
Collaborator

kwelch commented Oct 31, 2019

I think we need @coryhouse since appveyor did not report back properly and I am unable to merge this.

@nickytonline
Copy link
Collaborator

Yeah, I wonder why AppVeyor always hangs. 🤔

@coryhouse
Copy link
Owner

Works great for me! Thanks for your help!

I'm going to merge as is - Appveyor has been failing for awhile for unrelated reasons that I'll dig into separately.

@coryhouse coryhouse merged commit cf2b2c9 into coryhouse:master Oct 31, 2019
@nickytonline
Copy link
Collaborator

Thanks Cory!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants