Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix undefined variable in build.js #629

Merged
merged 2 commits into from
Sep 12, 2019
Merged

Fix undefined variable in build.js #629

merged 2 commits into from
Sep 12, 2019

Conversation

alepacheco
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Sep 12, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 91.525% when pulling 2c615e7 on alepacheco:patch-1 into e371105 on coryhouse:master.

nickytonline
nickytonline previously approved these changes Sep 12, 2019
View reviewed changes
@nickytonline
Copy link
Collaborator

Thanks for the PR!

@nickytonline nickytonline dismissed their stale review September 12, 2019 14:09

Oops. misread the changes in the wrong order.

@alepacheco
Copy link
Contributor Author

Seems that stats.hasErrors returns true even when empty. I made the PR because it seems like an issue. I will update it with a length check

nickytonline
nickytonline approved these changes Sep 12, 2019
View reviewed changes
Copy link
Collaborator

@nickytonline nickytonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. :shipit:

@coryhouse coryhouse merged commit 4950597 into coryhouse:master Sep 12, 2019
@coryhouse
Copy link
Owner

Looks good. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickytonline nickytonline nickytonline approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alepacheco @coveralls @nickytonline @coryhouse