Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incl additional FAQ details on VS Code debugging. #576

Merged
merged 1 commit into from
Jun 13, 2018
Merged

Incl additional FAQ details on VS Code debugging. #576

merged 1 commit into from
Jun 13, 2018

Conversation

mikedevita
Copy link
Contributor

@mikedevita mikedevita commented Jun 13, 2018

Pull Request Template

The code review checklist below is used for all pull requests.

  1. Review the list before submitting your pull request.
  2. Leave the list intact for the code reviewer's use.

Checklist

  • Latest code from master has been merged into the pull request branch
  • Honors the seven code virtues
    • Working, as opposed to incomplete
    • Unique, as opposed to duplicated
    • Simple, as opposed to complicated
    • Clear, as opposed to puzzling
    • Easy, as opposed to difficult
    • Developed, as opposed to primitive
    • Brief, as opposed to chatty
  • Code is camelCased
  • No commented out code (if required, place // TODO above with explanation)
  • No linting issues
  • Automated tests exist and pass
  • Build is successful (npm run build)
  • Works in IE 11, Chrome, Firefox, and Edge

Thanks!

❤️

@mikedevita mikedevita changed the title Incl additional details on VS Code debugging. Incl additional FAQ details on VS Code debugging. Jun 13, 2018
@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.379% when pulling 9429386 on mikedevita:patch-1 into 956c47e on coryhouse:master.

@nickytonline nickytonline merged commit bb2c53a into coryhouse:master Jun 13, 2018
@nickytonline
Copy link
Collaborator

Thanks for the PR Mike!

@mikedevita
Copy link
Contributor Author

NP! 😄

@mikedevita mikedevita deleted the patch-1 branch June 13, 2018 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants