Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order babel presets so they work correctly #491

Merged
merged 2 commits into from
Oct 22, 2017

Conversation

samit4me
Copy link
Contributor

Fixes #485

@coveralls
Copy link

coveralls commented Oct 20, 2017

Coverage Status

Coverage remained the same at 90.476% when pulling 3c0c13c on samit4me:class-properties-transform into 4fad0e5 on coryhouse:master.

@kwelch
Copy link
Collaborator

kwelch commented Oct 20, 2017

Is it possible to centralize them and get the proper order?

@samit4me
Copy link
Contributor Author

Yes I know what you mean, it doesn't look great. I don't know of any other way but that doesn't mean you can't. Will have another look when I get some more time.

@coryhouse
Copy link
Owner

I agree centralizing would be preferable if possible, but this reads clearly as is, so I'm good w/ merging as is if @kwelch and @nickytonline are.

@nickytonline
Copy link
Collaborator

I'm fine with it as is. 👍

@kwelch
Copy link
Collaborator

kwelch commented Oct 22, 2017

I pulled this locally to try it out and got runtime errors with the production build.

Uncaught Error: Module build failed: Error: Unexpected extra options ["react","stage-1"] passed to preset.

Dev environment appears to be running properly.

@coveralls
Copy link

coveralls commented Oct 22, 2017

Coverage Status

Coverage remained the same at 90.476% when pulling 90fe696 on samit4me:class-properties-transform into 4fad0e5 on coryhouse:master.

@kwelch
Copy link
Collaborator

kwelch commented Oct 22, 2017

Validated by changing SavingsForm to use arrow functions and static propTypes.

@kwelch
Copy link
Collaborator

kwelch commented Oct 22, 2017

AppVeyor died for a peerDep, but I don't see any issues with merging.

@kwelch kwelch merged commit 15963df into coryhouse:master Oct 22, 2017
@samit4me
Copy link
Contributor Author

Great pickup @kwelch, thank you for finding that issue ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants