-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Order babel presets so they work correctly #491
Conversation
Is it possible to centralize them and get the proper order? |
Yes I know what you mean, it doesn't look great. I don't know of any other way but that doesn't mean you can't. Will have another look when I get some more time. |
I agree centralizing would be preferable if possible, but this reads clearly as is, so I'm good w/ merging as is if @kwelch and @nickytonline are. |
I'm fine with it as is. 👍 |
I pulled this locally to try it out and got runtime errors with the production build.
Dev environment appears to be running properly. |
Validated by changing SavingsForm to use arrow functions and static propTypes. |
AppVeyor died for a peerDep, but I don't see any issues with merging. |
Great pickup @kwelch, thank you for finding that issue ✨ |
Fixes #485