Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make holder column of (non)-fungible-token tables nullable #220

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vanderheijden86
Copy link

@vanderheijden86 vanderheijden86 commented Dec 9, 2020

When using Confidential Identities in a setup where TXs are sent to an observer node, the observer node cannot resolve the AnonymousParty (resulting from Confidential Identities) into an actual Party. As such when storing Tokens that result from above TXs we see this error message:

|19:12:45,543|W|Node thread-5            | 3226|X500NameAsStringConverter|Identity service unable to resolve AbstractParty: Anonymous(DL3VRu4wU4GLpF9jpKhZk3GjjUUKTcGekbnkvCMRNT2pk8)|{fiber-id=10000314, flow-id=ad969caa-ede1-4fee-b90b-905a20dff485, flow-logic=com.sdx.observer.workflows.ReportTransactionResponderFlow, flow-logic-simple=ReportTransactionResponderFlow, invocation_id=a9d9ea04-07a2-4987-95dc-b0346fa2e6c1, invocation_timestamp=2020-12-08T18:12:45.215Z, origin=O=Q9IlF5pTCT, L=Zurich, C=CH, session_id=a9d9ea04-07a2-4987-95dc-b0346fa2e6c1, session_timestamp=2020-12-08T18:12:45.215Z, thread-id=3226, tx_id=E193CA840175CE5E2D695E14F07280723537FEB6BE8307E0648A1BA1DFEB2C47}|

|19:12:45,544|E|Node thread-5            | 3226|bc.spi.SqlExceptionHelper|NULL not allowed for column "HOLDER"; SQL statement:

This MR will resolve those issues as it will allow us to update the database queryable state table even when the value for holder is NULL.

@vanderheijden86 vanderheijden86 marked this pull request as ready for review December 9, 2020 10:18
@roastario
Copy link
Contributor

roastario commented Dec 11, 2020

thanks @vanderheijden86 - we have actually merged a very similar PR into: #221 which has added tests for database compatibility

This has now been "published" as 1.2.3-ALPHA, and we are working towards releasing the official 1.2.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants