fix(action): Add many validations for setvar #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## v3/dev #747 +/- ##
==========================================
- Coverage 81.89% 81.87% -0.02%
==========================================
Files 152 152
Lines 8345 8359 +14
==========================================
+ Hits 6834 6844 +10
- Misses 1290 1292 +2
- Partials 221 223 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
jcchavezs
reviewed
Mar 29, 2023
Co-authored-by: José Carlos Chávez <[email protected]>
jcchavezs
reviewed
Mar 29, 2023
Co-authored-by: José Carlos Chávez <[email protected]>
jcchavezs
reviewed
Mar 29, 2023
jcchavezs
reviewed
Mar 29, 2023
M4tteoP
reviewed
Mar 29, 2023
Co-authored-by: José Carlos Chávez <[email protected]>
anuraaga
approved these changes
Mar 29, 2023
| @@ -12,4 +27,22 @@ func TestSetvarInit(t *testing.T) { | |||
| t.Error("expected error ErrMissingArguments") | |||
| } | |||
| }) | |||
| t.Run("non-map variable", func(t *testing.T) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setvar wasn't doing many validations, and it was returning panics. Now it only allows TX as we don't support any other mutable variable