Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore warnings in 8.12 #18

Merged
merged 2 commits into from
Oct 5, 2020
Merged

Ignore warnings in 8.12 #18

merged 2 commits into from
Oct 5, 2020

Conversation

palmskog
Copy link
Member

@palmskog palmskog commented Oct 5, 2020

8.12 brought some new warnings to ignore, which I do here for both coq_makefile and Dune.

Also, in separate commit, switched CoInductive to Variant as per MathComp best practices.

@palmskog palmskog requested a review from chdoc October 5, 2020 09:54
chdoc
chdoc approved these changes Oct 5, 2020
View reviewed changes
Copy link
Member

@chdoc chdoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chdoc chdoc merged commit 62ad0b7 into master Oct 5, 2020
@chdoc chdoc mentioned this pull request Oct 5, 2020
Closed
@palmskog palmskog deleted the ignore-warnings branch October 5, 2020 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chdoc chdoc chdoc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@palmskog @chdoc