Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include OBS install steps for CentOS #1053

Merged
merged 1 commit into from
Sep 25, 2020
Merged

include OBS install steps for CentOS #1053

merged 1 commit into from
Sep 25, 2020

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented Sep 23, 2020

Signed-off-by: Lokesh Mandvekar [email protected]

@TomSweeneyRedHat @rhatdan PTAL

@lsm5 lsm5 mentioned this pull request Sep 23, 2020
Closed
rhatdan
rhatdan reviewed Sep 23, 2020
View reviewed changes
install.md Outdated Show resolved Hide resolved
@TomSweeneyRedHat
Copy link
Member

LGTM other than @rhatdan 's comment

@lsm5
Copy link
Member Author

lsm5 commented Sep 23, 2020

PTAL @ update.

mtrmac
mtrmac reviewed Sep 24, 2020
View reviewed changes
Copy link
Collaborator

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The page is getting a bit long and difficult to skim. Could you add

## Distribution Packages

and

## Building from Source

headers, and ###-level headers for the different distributions, please?

install.md Outdated Show resolved Hide resolved
TomSweeneyRedHat
TomSweeneyRedHat reviewed Sep 24, 2020
View reviewed changes
install.md Outdated Show resolved Hide resolved
TomSweeneyRedHat
TomSweeneyRedHat reviewed Sep 24, 2020
View reviewed changes
install.md Outdated Show resolved Hide resolved
@lsm5 @TomSweeneyRedHat
include OBS install steps for CentOS
248a1dd 
additional formatting changes

Co-authored-by: Tom Sweeney <[email protected]>
Signed-off-by: Lokesh Mandvekar <[email protected]>
@lsm5
Copy link
Member Author

lsm5 commented Sep 24, 2020

PTAL at updates. I made some more changes (for example curl instead of wget) as that was requested by someone on the podman docs.

@rhatdan
Copy link
Member

rhatdan commented Sep 25, 2020

LGTM

@rhatdan rhatdan merged commit 669627d into containers:master Sep 25, 2020
@lsm5 lsm5 deleted the centos-obs branch January 11, 2021 13:22
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rhatdan rhatdan rhatdan left review comments

@mtrmac mtrmac mtrmac left review comments

@TomSweeneyRedHat TomSweeneyRedHat TomSweeneyRedHat left review comments

Assignees
No one assigned
Labels
locked - please file new issue/PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lsm5 @TomSweeneyRedHat @rhatdan @mtrmac