CRI: Include sandbox ID in failed to recover error #9033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcantah
force-pushed
the
sberror-include-id
branch
from
5036498
to
7b9f57a
Compare
dmcgowan
reviewed
Aug 31, 2023
The failed to recover state message didn't include the ID making this not as useful as it could be.. This additionally moves some of the other logs to include the id for the sandbox/container as a field instead of part of a format string. Signed-off-by: Danny Canter <[email protected]>
dcantah
force-pushed
the
sberror-include-id
branch
from
7b9f57a
to
a2817ca
Compare
dmcgowan
approved these changes
Aug 31, 2023
|
/retest |
1 similar comment
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The failed to recover state message didn't include the ID making this not as useful as it could be..
This additionally moves some of the other logs to include the id for the sandbox/container as a field instead of part of a format string.