[Vendor] Update hcsshim to 0.8.18 #5673
Conversation
|
Hi @dcantah. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Build succeeded.
|
|
Build succeeded.
|
0.8.18 contains a fix for shim delete behavior, please see: microsoft/hcsshim#1041 There's no new vendored files as nothing from hcsshim/cmd/containerd-shim-runhcs-v1 gets imported here but for containerd releases the runhcs shim binary is built from whatever commit is vendored into containerd. Signed-off-by: Daniel Canter <[email protected]>
|
Build succeeded.
|
|
Good to mention that this resolves #5094. Will need a backport to 1.5. |
|
@kevpar Good call, updated pr description |
|
@kzys This vendor shouldn't actually bring in any new files, the code changed was under a path that nothing in containerd actually imports. The windows shim binary is built out of this repo based on the version of hcsshim vendored so that's the reason for bumping to the new release. |
|
@dcantah Oh I didn't know that and you've mentioned that in the PR description. Sorry! |
|
@kzys No worries, thanks for review! |
|
/ok-to-test |
|
/retest |
1 similar comment
|
/retest |
|
@kzys Are the e2e node tests just flaky recently? |
|
@dcantah Sadly yes. kubernetes/kubernetes#103429 |
|
/retest |
|
@dcantah Kubernetes folks have fixed the test. We are good to go. @containerd/committers Can someone take a look and merge? |
|
@estesp you're 10 seconds late :D |
0.8.18 contains a fix for shim delete behavior, please see:
microsoft/hcsshim#1041
There's no new vendored files as nothing from hcsshim/cmd/containerd-shim-runhcs-v1
gets imported here but for containerd releases the runhcs shim binary is built from whatever
commit is vendored into containerd.
This should resolve #5094
We'll need to additionally backport this to the 1.5 branch
Signed-off-by: Daniel Canter [email protected]