Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVX-2249: Create centralized custom dictionary for spell checking; fix spelling errors #871

Merged
merged 9 commits into from
Dec 3, 2020

Conversation

ybyzek
Copy link
Contributor

@ybyzek ybyzek commented Dec 3, 2020

Description

https://confluentinc.atlassian.net/browse/DEVX-2249

What behavior does this PR change, and why?

  1. Consistent spell check against validated word list
  2. Spelling error in Clickstream demo

Example how to run with the word list:

brew install aspell
for f in $(find . -name "*.rst") ; do aspell list -p ~/git/examples/docs/wordlist.txt < $f ; done  | sort  | uniq

Author Validation

Describe the validation already done, or needs to be done, by the PR submitter.

  • Documentation (local build)
  • clickstream (@bbejeck -- this PR surfaced an error in the clickstream demo itself! -- it was due to my spelling mistake)

Reviewer Tasks

Describe the tasks/validation that the PR submitter is requesting to be done by the reviewer.

@ybyzek ybyzek requested a review from a team December 3, 2020 02:37
@rspurgeon
Copy link
Contributor

@ybyzek very nice... can you add some instructions on how you used the word list?

@ybyzek ybyzek changed the title DEVX-2249: Create centralized custom dictionary for aspell to spell check IA assets DEVX-2249: Create centralized custom dictionary for spell checking; fix spelling errors Dec 3, 2020
@ybyzek
Copy link
Contributor Author

ybyzek commented Dec 3, 2020

@ybyzek very nice... can you add some instructions on how you used the word list?

@rspurgeon sure thing, added to Description of this PR and https://confluentinc.atlassian.net/browse/DEVX-2249

Copy link
Contributor

@rspurgeon rspurgeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ybyzek ybyzek merged commit afe8b09 into 6.0.1-post Dec 3, 2020
@ybyzek ybyzek deleted the DEVX-2249 branch December 3, 2020 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants