Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding smoothr #26054

Merged
merged 12 commits into from
Apr 21, 2024
Merged

adding smoothr #26054

merged 12 commits into from
Apr 21, 2024

Conversation

Rassine
Copy link
Contributor

@Rassine Rassine commented Apr 15, 2024

r-smoothr recipe was build thanks to conda skeleton CRAN
I marked miself as maintainer of the recipe

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/r-smoothr) and found it was in an excellent condition.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/r-smoothr) and found some lint.

Here's what I've got...

For recipes/r-smoothr:

  • noarch packages can't have skips with selectors. If the selectors are necessary, please remove noarch: generic.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/r-smoothr) and found some lint.

Here's what I've got...

For recipes/r-smoothr:

  • Non noarch packages should have r-base requirement without any version constraints.
  • Non noarch packages should have r-base requirement without any version constraints.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/r-smoothr) and found it was in an excellent condition.

@Rassine
Copy link
Contributor Author

Rassine commented Apr 16, 2024

@conda-forge/help-r please review this recipe

recipes/r-smoothr/build.sh Outdated Show resolved Hide resolved
recipes/r-smoothr/meta.yaml Outdated Show resolved Hide resolved
recipes/r-smoothr/meta.yaml Outdated Show resolved Hide resolved
recipes/r-smoothr/meta.yaml Outdated Show resolved Hide resolved
recipes/r-smoothr/meta.yaml Outdated Show resolved Hide resolved
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/r-smoothr) and found some lint.

Here's what I've got...

For recipes/r-smoothr:

  • The following maintainers have not yet confirmed that they are willing to be listed here: conda-forge/r. Please ask them to comment on this PR if they are.

@Rassine
Copy link
Contributor Author

Rassine commented Apr 19, 2024

Thanks a lot for your review! The package can still be added to conda-forge even with the tests failing for windows ?

@Rassine
Copy link
Contributor Author

Rassine commented Apr 19, 2024

@conda-forge/r clould you please be maintainer for this recipe ?

@dbast dbast merged commit cb99c0e into conda-forge:main Apr 21, 2024
2 of 5 checks passed
@dbast
Copy link
Member

dbast commented Apr 21, 2024

@Rassine thanks and welcome to conda-forge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants