-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
- [embree3] fix clang-cl by converting resource to UTF-8 #9822
Conversation
@@ -170,6 +170,13 @@ def _configure_cmake(self): | |||
return self._cmake | |||
|
|||
def build(self): | |||
# some compilers (e.g. clang) do not like UTF-16 sources |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for an additional safety, we may put it under if self.settings.compiler == "clang'
. but I've checked, and Visual Studio builds just fine with it.
Signed-off-by: SSE4 <[email protected]>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tricky
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this change should probably be reported upstream
closes: #9808
Specify library name and version: embree3/all
This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!
conan-center hook activated.