Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable data_type is incorrectly used #31

Merged
merged 1 commit into from
Jul 6, 2022

Conversation

praveenr019
Copy link
Contributor

This commit fixes below error, while running get-data.sh
get-data.sh: line 20: Downloading Common Crawl paths listings (${data_type^^} files of $CRAWL)...: bad substitution

@sebastian-nagel
Copy link
Contributor

Hi @praveenr019, the usage of "${var^^}" is intentional - it converts the variable value to uppercase characters. This is bash-specific syntax, possibly not supported by other shells. Which shell did you use?

@praveenr019
Copy link
Contributor Author

Thanks for the response.

I was using zsh actually. Feel free to close this issue.

@sebastian-nagel sebastian-nagel mentioned this pull request Jul 6, 2022
@sebastian-nagel sebastian-nagel merged commit 574e437 into commoncrawl:main Jul 6, 2022
@sebastian-nagel
Copy link
Contributor

Thanks, @praveenr019!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants