App improvements #1
Conversation
- Removed special chars around the message in the menubar - Call IOPSGetTimeRemainingEstimate() only once - Added comments - Using more properties to improve readability
- Calculcating => Calculating… - Unlimited => ∞
also updated copyright notice in info plist
We now show the Apple battery icon in the menubar
also ignore XCode userdata/workspace
also added links to contributors and how to contribute
|
Thank you very much for improving and adding more feature!! I really appreciate it! This is my first mac app so any improvements and suggestions etc are welcome :) I merged all your commits except one, the "CODE_SIGN_IDENTITY". |
|
Great that you accepted the pull request! I understand why you didn't accept the code sign commit, but you should sign the builds you publish with a Developer ID. If you don't code sign builds Gatekeeper will prevent users from installing it! |
|
oh, is that why. To get Developer ID I must have Mac Developer Program membership and it cost $99/year which is expensive. As a student that is too much for me =( It would be okey with one time fee, but per year is... |
|
I get that, my company has an Mac Developer Account and can sign builds, so maybe we can figure something out to get out signed builds. At least I can sign the builds I make and put online. :) |
|
I decided to join the program :P and now I can sign. |
|
Great to hear you've joined. :) Looking forward to a lot of signed builds! |
I made a number of improvements to your App to make it somewhat more useful for me. The main improvements/thing I added are:
If you want you can merge my improvements into your branch. I think I will improve my version somewhat further in the next days, will send a new pull request by then.