Removing \ from global functions #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r() in factory example and since it's unecessary
philsturgeon
pushed a commit
that referenced
this pull request
Jun 3, 2013
Removing \ from global functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per my message on:
78b8adc
Calls to global functions like var_dump don't need the \ prefix. It's only necessary to do this if you're using namespaces (this example doesn't) and you have a method that clashes with the global one. In this guide I think the \ prefix is confusing to users unfamiliar with namespaces so I suggest they are removed.
I've also included a minor amend to add parentheses after the instantiation of the singleton object to make this code a bit more obvious to users.
best wishes,
Si