Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show searched video in new tab. issue #1774 #1782

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

asifurrahaman754
Copy link
Member

@asifurrahaman754 asifurrahaman754 commented Oct 7, 2023

Addressing issue #1774,

Now users can select if they want to open a new tab for the search.

new feature option is in: General menu

@asifurrahaman754 asifurrahaman754 changed the title feat: add show video in new tab. issue #1774 feat: show searched video in new tab. issue #1774 Oct 7, 2023
@ImprovedTube ImprovedTube merged commit 0de20b2 into code-charity:master Oct 10, 2023
@ImprovedTube
Copy link
Member

wow! thanks!
When i wished😳 there might be a minimal solution, i was just dreaming of <a target="_blank">

I was exploring the codebase, also I was not familiar with extension development. But it was a great learning.

Excited you paid the hard effort to start something new!
Hope you will repeat, since most of our tasks still take less code than & can be very motivating considering the amount of users. and i want to make them rewarding as much too
(or at least X times more rewarding than Hacktober-Fest alone)


  • "Open in a new tab" isn't a complete name: "Search: Open in a new tab" (or in a new section "Search" > "Open in a new tab")
    • ( when the name is final, it can appear more prominently, yet you moved it to the bottom, so that it is great to send to every user )

@asifurrahaman754 asifurrahaman754 deleted the new-tab-feat branch October 10, 2023 15:39
@ImprovedTube
Copy link
Member

hi @asifurrahaman754 adf7c62

@asifurrahaman754
Copy link
Member Author

hi @asifurrahaman754 adf7c62

Hi

ImprovedTube added a commit that referenced this pull request Jan 12, 2024
feat: show searched video in new tab. issue #1774
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants