-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serverless Follow-up #11989
Serverless Follow-up #11989
Conversation
Files changed: _includes/cockroachcloud/planning-your-serverless-cluster.md |
Request unit definition in the Concepts table missing the word of |
✔️ Netlify Preview 🔨 Explore the source changes: 923a6c6 🔍 Inspect the deploy log: https://app.netlify.com/sites/cockroachdb-docs/deploys/616db5044815f00007ae4a35 😎 Browse the preview: https://deploy-preview-11989--cockroachdb-docs.netlify.app |
There are two tennat 4s in the Architecture diagram, is that something that can happen? |
✔️ Netlify Preview 🔨 Explore the source changes: 365beb6 🔍 Inspect the deploy log: https://app.netlify.com/sites/cockroachdb-docs/deploys/6176e045cfacd50008a57668 😎 Browse the preview: https://deploy-preview-11989--cockroachdb-docs.netlify.app |
yep! just confirmed with Paul. 1 tenant:many sql pods is allowed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @gemma-shay and @ianjevans)
cockroachcloud/architecture.md, line 31 at r3 (raw file):
**Storage** | Disk space for permanently storing data over time. All data in {{ site.data.products.serverless }} is automatically replicated three times and distributed across Availability Zones to survive outages. Storage is measured in units of GiB-months, which is the amount of data stored multiplied by how long it was stored. Storing 10 GiB for a month and storing 1 GiB for 10 months are both 10 GiB-months. The storage you see in the [Cluster Overview](serverless-cluster-management.html#view-cluster-overview) page is the amount of data before considering the replication multiplier. {% comment %} **Projected usage** | The amount of usage that Cockroach Labs projects a cluster will consume during a billing period. This is important for setting a cluster’s spend limit, because we always reserve enough budget to pay for storage for the rest of the billing period. You can see your projected usage while [editing your spend limit](serverless-cluster-management.html#edit-your-spend-limit).
is this part of the MVP? I thought this wasn't @jramos-crl ?
commented it out so we can add it back in whenever it's ready |
On the diagrams, when we say high traffic w low traffic is it high/low traffic from the POV of the host cluster or the end user? In both cases, extra SQL pods are spun up but I did notice that in the high traffic diagram, you have multiple apps connecting. I think that could be confusing potentially to the end user. Does the end user care if there are lots of apps connecting to the host cluster or do they care that THEIR app is seeing a lot of traffic? I think if we want to tell the story from a tenant's perspective, we should show only 1 app. WDYT? |
The other nit is that the two diagrams on this page look very different in terms of patterns, fonts, etc. That's a little odd but not a breaking thing, over time I'd love for these to look consistent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @ianjevans and @kannanlakshmi)
cockroachcloud/architecture.md, line 31 at r3 (raw file):
Previously, gemma-shay (Gemma Shay) wrote…
commented it out so we can add it back in whenever it's ready
Right - not part of the MVP, so yes we should keep the projected usage out for now.
@ianjevans can we merge #11990 and then this today? |
Yes. I'll ping you to coordinate PRs to avoid conflicts. |
Adding new diagrams and some missed comments and suggestions from #10900