Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FixedTyping for League Entries endpoint #93

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

annnoo
Copy link

@annnoo annnoo commented Mar 14, 2020

In the typing the Entries endpoint is called via kayn.League.Entries.bySummonerId(id), however in the LeagueEntriesEndpointV4 it is defined as Entries.by.summonerID(id).
This leads to:
TypeError: kayn.League.Entries.bySummonerID is not a function

In the typing the Entries endpoint is called via kayn.League.Entries.bySummonerId(id), however in the LeagueEntriesEndpointV4  it is defined as Entries.by.summonerID(id).
This leads to: 
TypeError: kayn.League.Entries.bySummonerID is not a function
@annnoo
Copy link
Author

annnoo commented Mar 14, 2020

a@^4.0.0ise@^2.1.0imic-fn@^1.0.0error Your lockfile needs to be updated, but yarn was run with `--frozen-lockfile`.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

@cnguy would be great if you could look into this :)

@johncovv
Copy link

I'm having the same problem, it would be nice if he could fix it. Did you manage to do an external typing that goes over this one?

@annnoo
Copy link
Author

annnoo commented Nov 2, 2020

I guess this project is sadly dead. I forked the repo, but had no time yet to set up everything (build pipeline, etc).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants